Remove platform code from pipedv1 #5060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
khanhtc1202
requested review from
Warashi,
ffjlabo,
kentakozuka,
nghialv and
t-kikuc
as code owners
t-kikuc
previously approved these changes
Jul 19, 2024
Member
t-kikuc
left a comment
t-kikuc
left a comment
There was a problem hiding this comment.
I checked only pipedv1 code is changed.
Signed-off-by: khanhtc1202 <[email protected]>
Member
Author
|
@t-kikuc Thanks, could you re-approve 🙏 |
t-kikuc
approved these changes
Jul 19, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5060 +/- ##
==========================================
+ Coverage 22.45% 22.70% +0.25%
==========================================
Files 523 407 -116
Lines 57108 43123 -13985
==========================================
- Hits 12825 9793 -3032
+ Misses 43255 32551 -10704
+ Partials 1028 779 -249 ☔ View full report in Codecov by Sentry. |
This was referenced Jul 29, 2024
Merged
This was referenced Aug 13, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Follow #5051
Does this PR introduce a user-facing change?: