Skip to content

Conversation

@khanhtc1202
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Follow PR #5015

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@codecov
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.47%. Comparing base (d362879) to head (51538ca).
Report is 674 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5047      +/-   ##
==========================================
+ Coverage   22.45%   22.47%   +0.02%     
==========================================
  Files         522      522              
  Lines       57041    57041              
==========================================
+ Hits        12809    12822      +13     
+ Misses      43204    43192      -12     
+ Partials     1028     1027       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MEMO:
The implementation will be something like this.

// determineVersions decides artifact versions of an application.
// It finds all container images that are being specified in the workload manifests then returns their names, version numbers, and urls.
func determineVersions(manifests []provider.Manifest) ([]*model.ArtifactVersion, error) {

@khanhtc1202 khanhtc1202 enabled auto-merge (squash) July 16, 2024 09:32
Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@khanhtc1202 khanhtc1202 merged commit 2841574 into master Jul 16, 2024
@khanhtc1202 khanhtc1202 deleted the add-determine-versions branch July 16, 2024 09:33
@github-actions github-actions bot mentioned this pull request Jul 18, 2024
@github-actions github-actions bot mentioned this pull request Jul 18, 2024
This was referenced Jul 29, 2024
This was referenced Aug 13, 2024
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
This was referenced Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants