Update docs for Google SSO #5044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
ffjlabo
requested review from
Warashi,
kentakozuka,
khanhtc1202,
nghialv and
t-kikuc
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5044 +/- ##
==========================================
+ Coverage 22.45% 22.47% +0.01%
==========================================
Files 522 522
Lines 57041 57041
==========================================
+ Hits 12809 12818 +9
+ Misses 43204 43195 -9
Partials 1028 1028 ☔ View full report in Codecov by Sentry. |
t-kikuc
reviewed
Jul 16, 2024
Signed-off-by: Yoshiki Fujikane <[email protected]>
Member
Author
|
Thank you! removed in 544c9bb |
This was referenced Jul 29, 2024
Merged
This was referenced Aug 13, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Google SSO is not yet supported, but some documents describe it.
It's confusing, so I fixed them.
This is because we previously planned the feature but didn't Implement it.
Which issue(s) this PR fixes:
Part of #1161
Does this PR introduce a user-facing change?: