Skip to content

Conversation

@Warashi
Copy link
Member

@Warashi Warashi commented Jul 16, 2024

What this PR does / why we need it:

As discussed in this comment, I add the working_dir field to the PlanPluginInput message.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Comment on lines +74 to +76
// The workking directory to use in plugin.
// This directory contains the cloned deploy source with the directory name "deploy_source".
string working_dir = 6;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khanhtc1202
I think the working dir passed to the plugin should contain the deploy source.
On the other hand, this working_dir is used with os.MkdirTemp, so we should not place the deploy source at the root of this directory.
So, I documented that the deploy source is placed within the directory named "deploy_source."
WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's fine 👍

@codecov
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.46%. Comparing base (d362879) to head (131fcee).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5043      +/-   ##
==========================================
+ Coverage   22.45%   22.46%   +0.01%     
==========================================
  Files         522      522              
  Lines       57041    57041              
==========================================
+ Hits        12809    12816       +7     
+ Misses      43204    43198       -6     
+ Partials     1028     1027       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Warashi Warashi marked this pull request as ready for review July 16, 2024 08:20
@Warashi Warashi enabled auto-merge (squash) July 16, 2024 08:23
@Warashi Warashi disabled auto-merge July 16, 2024 08:25
@Warashi
Copy link
Member Author

Warashi commented Jul 16, 2024

I think it's simpler than this PR to pass the DeploySource information directly to the plugin.
So we start from that point and then pass workspace_dir, working_dir, temp_dir, or something similar if we need it.

@Warashi Warashi closed this Jul 16, 2024
@Warashi Warashi deleted the pipedv1-plugin-input-working-dir branch August 30, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants