Skip to content

Conversation

@Warashi
Copy link
Member

@Warashi Warashi commented Jul 16, 2024

What this PR does / why we need it:

  • Upgrade google-cloud-sdk to latest
  • Use x86_64 version of google-cloud-sdk

Which issue(s) this PR fixes:

We upgraded the alpine to 3.20 in this PR
Alpine 3.20 uses the newer Python, so this issue occurred.
https://issuetracker.google.com/issues/303280713?pli=1

The issue is already fixed in the latest google-cloud-sdk, so I upgrade it.

Fixes #

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Warashi added 2 commits July 16, 2024 10:20
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@Warashi
Copy link
Member Author

Warashi commented Jul 16, 2024

I tested with a command below

docker buildx build --platform linux/amd64 --file cmd/pipecd/Dockerfile . -t pipecd-debug

@Warashi Warashi enabled auto-merge (squash) July 16, 2024 01:27
Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Warashi Warashi merged commit 3dbc2be into master Jul 16, 2024
@Warashi Warashi deleted the google-cloud-sdk-upgrade branch July 16, 2024 01:28
@github-actions github-actions bot mentioned this pull request Jul 18, 2024
t-kikuc pushed a commit that referenced this pull request Jul 18, 2024
* Use x86_64 version of google-cloud-sdk

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

* Upgrade google-cloud-sdk

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

---------

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
t-kikuc pushed a commit that referenced this pull request Jul 18, 2024
* Use x86_64 version of google-cloud-sdk

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

* Upgrade google-cloud-sdk

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

---------

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
t-kikuc added a commit that referenced this pull request Jul 18, 2024
* fix: upgrade @loadable/component from 5.14.1 to 5.16.4 (#5000)

Snyk has created this PR to upgrade @loadable/component from 5.14.1 to 5.16.4.

See this package in yarn:
@loadable/component

See this project in Snyk:
https://app.snyk.io/org/pipecd/project/f41c5767-b506-4f59-beb9-ef662258eb9a?utm_source=github&utm_medium=referral&page=upgrade-pr

Signed-off-by: khanhtc1202 <[email protected]>
Co-authored-by: snyk-bot <[email protected]>
Signed-off-by: t-kikuc <[email protected]>

* fix: upgrade @reduxjs/toolkit from 1.8.5 to 1.9.7 (#4999)

Snyk has created this PR to upgrade @reduxjs/toolkit from 1.8.5 to 1.9.7.

See this package in yarn:
@reduxjs/toolkit

See this project in Snyk:
https://app.snyk.io/org/pipecd/project/f41c5767-b506-4f59-beb9-ef662258eb9a?utm_source=github&utm_medium=referral&page=upgrade-pr

Co-authored-by: snyk-bot <[email protected]>
Signed-off-by: t-kikuc <[email protected]>

* fix: upgrade react-router-dom from 5.2.0 to 5.3.4 (#5001)

Snyk has created this PR to upgrade react-router-dom from 5.2.0 to 5.3.4.

See this package in yarn:
react-router-dom

See this project in Snyk:
https://app.snyk.io/org/pipecd/project/f41c5767-b506-4f59-beb9-ef662258eb9a?utm_source=github&utm_medium=referral&page=upgrade-pr

Signed-off-by: t-kikuc <[email protected]>
Co-authored-by: snyk-bot <[email protected]>
Co-authored-by: Tetsuya Kikuchi <[email protected]>
Signed-off-by: t-kikuc <[email protected]>

* fix: upgrade grpc-web from 1.0.7 to 1.5.0 (#4984)

Snyk has created this PR to upgrade grpc-web from 1.0.7 to 1.5.0.

See this package in yarn:
grpc-web

See this project in Snyk:
https://app.snyk.io/org/pipecd/project/f41c5767-b506-4f59-beb9-ef662258eb9a?utm_source=github&utm_medium=referral&page=upgrade-pr

Co-authored-by: snyk-bot <[email protected]>
Signed-off-by: t-kikuc <[email protected]>

* [Snyk] Security upgrade alpine from 3.17 to 3.20 (#5014)

* fix: docs/Dockerfile to reduce vulnerabilities

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-ALPINE317-OPENSSL-7413590
- https://snyk.io/vuln/SNYK-ALPINE317-OPENSSL-7413590
- https://snyk.io/vuln/SNYK-ALPINE317-OPENSSL-7413591
- https://snyk.io/vuln/SNYK-ALPINE317-OPENSSL-7413591

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

* Bump alpine

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

---------

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Co-authored-by: snyk-bot <[email protected]>
Co-authored-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: t-kikuc <[email protected]>

* Upgrade google-cloud-sdk (#5042)

* Use x86_64 version of google-cloud-sdk

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

* Upgrade google-cloud-sdk

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

---------

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: t-kikuc <[email protected]>

* feat: add support mention slack groups for NotificationReceiverSlack and NotificationMention (#4903)

* feat: add support mentione groups for NotifactionReceiverSlack and slackGroups for NotificationMention

Signed-off-by: hungran <[email protected]>

* remove change in docs v0.47.x

Signed-off-by: hungran <[email protected]>

* update docs

Signed-off-by: hungran <[email protected]>

* update logic for having getGroupsAsString()

Signed-off-by: hungran <[email protected]>

* using <!subteam^ID> for group mentioning

Signed-off-by: hungran <[email protected]>

* typo

Signed-off-by: hungran <[email protected]>

* call both getAccountsAsString and getGroupsAsString

Signed-off-by: hungran <[email protected]>

* revert change pkg/model/notificationevent.pb.go

Signed-off-by: hungran <[email protected]>

* use same format for group <!subteam^ID>

Signed-off-by: hungran <[email protected]>

* same method to format slack group

Signed-off-by: hungran <[email protected]>

* following slack api, !subteam^ is a literal string that should not change

Signed-off-by: hungran <[email protected]>

* feat: add slackUsers field and mark slack as deprecated field

Signed-off-by: hungran <[email protected]>

* revert pkg/model/notificationevent.pb.go

Signed-off-by: hungran <[email protected]>

* update doc Using the groupID or teamID in the documents makes it easier for users to use this feature.

Signed-off-by: hungran <[email protected]>

* add code gen

Signed-off-by: hungran <[email protected]>

* adjust mention users and slack logic

Signed-off-by: hungran <[email protected]>

* unify the process to get users and groups in the same method

Signed-off-by: hungran <[email protected]>

---------

Signed-off-by: hungran <[email protected]>
Signed-off-by: t-kikuc <[email protected]>

* Ignore `desiredCount` of ECS when it's 0 or not set for AutoScaling (#5030)

* add a flag: ignoreDesiredCountOnUpdate

Signed-off-by: t-kikuc <[email protected]>

* ignore desiredCount on updateService if needed

Signed-off-by: t-kikuc <[email protected]>

* Add a flag ignoreDesiredCountOnUpdate into each func

Signed-off-by: t-kikuc <[email protected]>

* Format func params and comment

Signed-off-by: t-kikuc <[email protected]>

* add docs

Signed-off-by: t-kikuc <[email protected]>

* fix tests: add a missing attribute

Signed-off-by: t-kikuc <[email protected]>

* recover desiredCount in CreateService (mistake)

Signed-off-by: t-kikuc <[email protected]>

* add mentioning driftdetection

Signed-off-by: t-kikuc <[email protected]>

* Revert changes of adding ignoreDesiredCountOnUpdate

This reverts commit a0f3459.

Signed-off-by: t-kikuc <[email protected]>

* Revert commits of adding ignoreDesiredCount"

This reverts commit 7d65824.

Signed-off-by: t-kikuc <[email protected]>

* Revert "add docs"

This reverts commit dcd7dc9.

Signed-off-by: t-kikuc <[email protected]>

* Revert "Format func params and comment"

This reverts commit 5103158.

Signed-off-by: t-kikuc <[email protected]>

* Revert "Add a flag ignoreDesiredCountOnUpdate into each func"

This reverts commit d17a9b7.

Signed-off-by: t-kikuc <[email protected]>

* Revert "ignore desiredCount on updateService if needed"

This reverts commit cf3efbf.

Signed-off-by: t-kikuc <[email protected]>

* Revert "add a flag: ignoreDesiredCountOnUpdate"

This reverts commit 6b2af75.

Signed-off-by: t-kikuc <[email protected]>

* ignore updating desiredCount if it's 0 or not defined

Signed-off-by: t-kikuc <[email protected]>

* Use pruning when 'recreate' is on

Signed-off-by: t-kikuc <[email protected]>

* add docs

Signed-off-by: t-kikuc <[email protected]>

* refine docs

Signed-off-by: t-kikuc <[email protected]>

* Clarify procedure of configuring

Signed-off-by: t-kikuc <[email protected]>

---------

Signed-off-by: t-kikuc <[email protected]>

---------

Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: hungran <[email protected]>
Co-authored-by: Khanh Tran <[email protected]>
Co-authored-by: snyk-bot <[email protected]>
Co-authored-by: Chris Aniszczyk <[email protected]>
Co-authored-by: Shinnosuke Sawada-Dazai <[email protected]>
Co-authored-by: Henry Vu <[email protected]>
@github-actions github-actions bot mentioned this pull request Jul 18, 2024
This was referenced Jul 29, 2024
This was referenced Aug 13, 2024
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
This was referenced Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants