Skip to content

Conversation

@tetsuya28
Copy link
Contributor

What this PR does / why we need it:
We need to add custom pod annotations for piped pod with Helm.

Which issue(s) this PR fixes:

Fixes #5033

Does this PR introduce a user-facing change?:

  • How are users affected by this change: Enable to add pod annotations, but default is empty, means no breaking changes
  • Is this breaking change: No
  • How to migrate (if breaking change): -

helm template demo piped --debug with podAnnotations ( podAnnotationsInjected: true )

# Source: piped/templates/deployment.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: demo-piped
  labels:
    helm.sh/chart: piped-0.0.0
    app.kubernetes.io/name: piped
    app.kubernetes.io/instance: demo
    app.kubernetes.io/version: "0.0.0"
    app.kubernetes.io/managed-by: Helm
spec:
  replicas: 1
  strategy:
    type: Recreate
  selector:
    matchLabels:
      app.kubernetes.io/name: piped
      app.kubernetes.io/instance: demo
  template:
    metadata:
      labels:
        app.kubernetes.io/name: piped
        app.kubernetes.io/instance: demo
      annotations:
        sidecar.istio.io/inject: "false"
        rollme: "ff8ru"
+       podAnnotationsInjected: true

@khanhtc1202
Copy link
Member

@tetsuya28 please sigh off the commit follow this instruction 🙏
https://github.com/pipe-cd/pipecd/pull/5034/checks?check_run_id=27358501377

@tetsuya28 tetsuya28 force-pushed the add-pod-annotations-piped-helm branch from 461771c to 3a11f23 Compare July 12, 2024 06:26
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🐰

Copy link
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Warashi Warashi merged commit 7ca5c05 into pipe-cd:master Jul 12, 2024
khanhtc1202 pushed a commit that referenced this pull request Jul 12, 2024
Signed-off-by: tetsuya28 <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
@github-actions github-actions bot mentioned this pull request Jul 18, 2024
t-kikuc pushed a commit that referenced this pull request Jul 18, 2024
@t-kikuc t-kikuc mentioned this pull request Jul 18, 2024
t-kikuc pushed a commit that referenced this pull request Jul 18, 2024
Signed-off-by: tetsuya28 <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
khanhtc1202 pushed a commit that referenced this pull request Jul 18, 2024
Signed-off-by: tetsuya28 <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Co-authored-by: Tetsuya Yamamoto <[email protected]>
@github-actions github-actions bot mentioned this pull request Jul 18, 2024
This was referenced Jul 29, 2024
This was referenced Aug 13, 2024
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
This was referenced Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable to add custom annotations for piped pod

3 participants