Skip to content

Conversation

@t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Jul 4, 2024

What this PR does / why we need it:

The latest version of docs is still v0.47.x although we released v0.48.0.
The cause is not clear yet.

I executed the following command to fix it.

# Update docs/main.go
sed -i '' "s/const latestPath.*/const latestPath = \"\/docs-"$VERSION"\/\"/g" docs/main.go

Which issue(s) this PR fixes:

N/A

Does this PR introduce a user-facing change?: no

  • How are users affected by this change: no
  • Is this breaking change: no
  • How to migrate (if breaking change): no

Copy link
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@t-kikuc t-kikuc enabled auto-merge (squash) July 4, 2024 04:22
@codecov
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.44%. Comparing base (6439f97) to head (d441273).
Report is 688 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5025      +/-   ##
==========================================
- Coverage   22.45%   22.44%   -0.01%     
==========================================
  Files         520      520              
  Lines       56852    56852              
==========================================
- Hits        12765    12760       -5     
- Misses      43061    43066       +5     
  Partials     1026     1026              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Warashi
Copy link
Member

Warashi commented Jul 4, 2024

The cause is ./hack/gen-release-docs.sh expects sed is the BSD version, it's the default of macOS.
I'm using the GNU version, and its -i option behavior is different from the BSD version.

@t-kikuc t-kikuc changed the title Fix: Update latest version of docs Fix: Update latest version of docs to v0.48.x Jul 4, 2024
Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@t-kikuc t-kikuc merged commit 232b9d8 into master Jul 4, 2024
@t-kikuc t-kikuc deleted the fix-docs-latest-version branch July 4, 2024 04:29
khanhtc1202 pushed a commit that referenced this pull request Jul 12, 2024
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
This was referenced Jul 18, 2024
This was referenced Jul 29, 2024
This was referenced Aug 13, 2024
ffjlabo pushed a commit that referenced this pull request Aug 15, 2024
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
@ffjlabo ffjlabo mentioned this pull request Aug 15, 2024
ffjlabo added a commit that referenced this pull request Aug 15, 2024
* Fix: Update latest version of docs (#5025)

Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>

* Update to v0.48.6 (#5137)

Signed-off-by: Yoshiki Fujikane <[email protected]>

Signed-off-by: Yoshiki Fujikane <[email protected]>

---------

Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Co-authored-by: Tetsuya Kikuchi <[email protected]>
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
This was referenced Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants