Implement envoy route config for opentelemetry-collector #5016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shinnosuke Sawada <[email protected]>
Signed-off-by: Shinnosuke Sawada <[email protected]>
Warashi
requested review from
ffjlabo,
kentakozuka,
khanhtc1202,
nghialv and
t-kikuc
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5016 +/- ##
=======================================
Coverage 22.47% 22.47%
=======================================
Files 519 519
Lines 56792 56792
=======================================
Hits 12762 12762
Misses 43003 43003
Partials 1027 1027 ☔ View full report in Codecov by Sentry. |
ffjlabo
reviewed
Jul 8, 2024
Comment on lines
+129
to
+130
| - match: # We want to protect the opentelemetry service with envoy ext_authz, so this route must not turn off ext_authz. | ||
| prefix: "/opentelemetry.proto.collector.trace.v1.TraceService/" |
Member
There was a problem hiding this comment.
[ask] Is this it? Just to be sure.
https://github.com/open-telemetry/opentelemetry-proto/blob/ff457cecf46cf219602e587d86d66f3b8cb3efe6/opentelemetry/proto/collector/trace/v1/trace_service.proto#L30
Piped calls the rpc method in the opentelemetry.proto.collector.trace.v1.TraceService to send the data to opentelemetry-collector.
kumo-rn5s
pushed a commit
to kumo-rn5s/pipecd
that referenced
this pull request
Jul 11, 2024
* Implement envoy route config for opentelemetry-collector Signed-off-by: Shinnosuke Sawada <[email protected]> * Add annotation for gateway to rollout when its config changes Signed-off-by: Shinnosuke Sawada <[email protected]> --------- Signed-off-by: Shinnosuke Sawada <[email protected]> Signed-off-by: kumo-rn5s <[email protected]>
khanhtc1202
pushed a commit
that referenced
this pull request
Jul 12, 2024
* Implement envoy route config for opentelemetry-collector Signed-off-by: Shinnosuke Sawada <[email protected]> * Add annotation for gateway to rollout when its config changes Signed-off-by: Shinnosuke Sawada <[email protected]> --------- Signed-off-by: Shinnosuke Sawada <[email protected]> Signed-off-by: khanhtc1202 <[email protected]>
This was referenced Jul 29, 2024
Merged
This was referenced Aug 13, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR modifies the envoy config to add a route to the OpenTelemetry Collector.
Which issue(s) this PR fixes:
Part of #4977
Does this PR introduce a user-facing change?: