-
Notifications
You must be signed in to change notification settings - Fork 204
[ECS] Implement LiveStateStore&Reporter for ECS #4979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
This reverts commit cbac8ed. Signed-off-by: t-kikuc <[email protected]>
This reverts commit 9304b16. Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
ffjlabo
previously approved these changes
Jul 18, 2024
Member
ffjlabo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Member
Author
Warashi
previously approved these changes
Jul 22, 2024
Member
Warashi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
ffjlabo
previously approved these changes
Jul 22, 2024
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Warashi
approved these changes
Jul 22, 2024
ffjlabo
approved these changes
Jul 22, 2024
This was referenced Jul 29, 2024
Merged
This was referenced Aug 13, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #4905
Does this PR introduce a user-facing change?: NO
How it works
Resources to store:
Note: Only services that have the
pipecd-dev-applicationtag will be stored.Image
Example of the state of an application:
{ "application_id": "8da4d78d-7d33-4146-b664-6843ea0edbaf", "piped_id": "27535d51-0dc7-4e42-8359-a0f5019aebb8", "project_id": "test-project", "kind": 5, "ecs": { "resources": [ { "id": "arn:aws:ecs:ap-northeast-1:<account-id>:service/t-kikuc-dev-cluster/ecs-diff-bool", "owner_ids": [ "arn:aws:ecs:ap-northeast-1:<account-id>:cluster/t-kikuc-dev-cluster" ], "parent_ids": [ "arn:aws:ecs:ap-northeast-1:<account-id>:cluster/t-kikuc-dev-cluster" ], "name": "ecs-diff-bool", "kind": "Service", "health_status": 1, "health_description": "Service's status is ACTIVE", "created_at": 1718709026, "updated_at": 1718709026 }, { "id": "arn:aws:ecs:ap-northeast-1:<account-id>:task-set/t-kikuc-dev-cluster/ecs-diff-bool/ecs-svc/9473360680098220823", "owner_ids": [ "arn:aws:ecs:ap-northeast-1:<account-id>:service/t-kikuc-dev-cluster/ecs-diff-bool" ], "parent_ids": [ "arn:aws:ecs:ap-northeast-1:<account-id>:service/t-kikuc-dev-cluster/ecs-diff-bool" ], "name": "arn:aws:ecs:ap-northeast-1:<account-id>:task-set/t-kikuc-dev-cluster/ecs-diff-bool/ecs-svc/9473360680098220823", "kind": "TaskSet", "health_status": 1, "health_description": "TaskSet's status is PRIMARY", "created_at": 1718710039, "updated_at": 1718710100 }, { "id": "arn:aws:ecs:ap-northeast-1:<account-id>:task/t-kikuc-dev-cluster/999a56ede3ae4eba854492bb9d847572", "owner_ids": [ "arn:aws:ecs:ap-northeast-1:<account-id>:task-set/t-kikuc-dev-cluster/ecs-diff-bool/ecs-svc/9473360680098220823" ], "parent_ids": [ "arn:aws:ecs:ap-northeast-1:<account-id>:task-set/t-kikuc-dev-cluster/ecs-diff-bool/ecs-svc/9473360680098220823" ], "name": "arn:aws:ecs:ap-northeast-1:<account-id>:task/t-kikuc-dev-cluster/999a56ede3ae4eba854492bb9d847572", "kind": "Task", "health_description": "Task's last status is RUNNING and the health status is UNKNOWN", "created_at": 1718710046, "updated_at": 1718710046 }, { "id": "arn:aws:ecs:ap-northeast-1:<account-id>:task/t-kikuc-dev-cluster/b83478ea8e8d4b7f9428ebbb0bf570e1", "owner_ids": [ "arn:aws:ecs:ap-northeast-1:<account-id>:task-set/t-kikuc-dev-cluster/ecs-diff-bool/ecs-svc/9473360680098220823" ], "parent_ids": [ "arn:aws:ecs:ap-northeast-1:<account-id>:task-set/t-kikuc-dev-cluster/ecs-diff-bool/ecs-svc/9473360680098220823" ], "name": "arn:aws:ecs:ap-northeast-1:<account-id>:task/t-kikuc-dev-cluster/b83478ea8e8d4b7f9428ebbb0bf570e1", "kind": "Task", "health_description": "Task's last status is RUNNING and the health status is UNKNOWN", "created_at": 1718710046, "updated_at": 1718710046 } ] }, "version": { "timestamp": 1718710910 } }UI will be like this (not implemented yet):
