-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Analytics 4 (GA4): configure CNCF site ID #4940
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you so much!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @chalin @nate-double-u 😄
@chalin Looks like the commit has not been signed yet. Could you sign the commit with |
Hi @chalin, sorry for the wrong mentioning 🙏 It was an issue on the DCO bot GitHub App we used for PipeCD. Let us check and update from our end. Thanks for your quick response 😄 |
Base branch was modified
Hi @chalin, The DCO check app has been restored to work. Please check this log and fix the DCO issue following its instructions. Sorry for the inconvenient 🙏 (If you don't want to workaround with git commit command, I think close and reopen the PR or re-edit from web UI as you did could help) |
Reopen to trigger DCO check run 👀 But it look like it failed 🤔 |
@khanhtc1202 - I'll fix this today. |
- Contenxt: https://cncfservicedesk.atlassian.net/browse/CNCFSD-1859 Signed-off-by: Patrice Chalin <[email protected]>
Fixed DCO issue. (It's annoying that this can't be fixed via the web i/f for patch PRs 🤷🏼♂️. Anyhow, it's done now.) |
@chalin @nate-double-u thank you all for your support 😄 |
/cc @nate-double-u