-
Notifications
You must be signed in to change notification settings - Fork 204
[doc] Add authentication to GitHub Container Registry to the Prerequisites section in QuickStart Page #4773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ffjlabo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch 👍 Thank you for the contribution!
Could you signoff your commits with git commit -s 🙏
https://github.com/pipe-cd/pipecd/blob/master/CONTRIBUTING.md#contributor-license-agreement
Also, could you add the same line to the other version's docs?
- docs/content/en/docs-dev/quickstart/_index.md
- docs/content/en/docs-v0.39.x/quickstart/_index.md
- docs/content/en/docs-v0.40.x/quickstart/_index.md
- docs/content/en/docs-v0.41.x/quickstart/_index.md
- docs/content/en/docs-v0.42.x/quickstart/_index.md
- docs/content/en/docs-v0.43.x/quickstart/_index.md
- docs/content/en/docs-v0.44.x/quickstart/_index.md
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4773 +/- ##
=======================================
Coverage 31.03% 31.03%
=======================================
Files 225 225
Lines 26353 26353
=======================================
Hits 8179 8179
Misses 17521 17521
Partials 653 653 ☔ View full report in Codecov by Sentry. |
…section in QuickStart Page Signed-off-by: tatsuya0429 <[email protected]>
Signed-off-by: tatsuya0429 <[email protected]>
Signed-off-by: tatsuya0429 <[email protected]>
Signed-off-by: tatsuya0429 <[email protected]>
Signed-off-by: tatsuya0429 <[email protected]>
Signed-off-by: tatsuya0429 <[email protected]>
Signed-off-by: tatsuya0429 <[email protected]>
Signed-off-by: tatsuya0429 <[email protected]>
|
@ffjlabo |
ffjlabo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
t-kikuc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!!
What this PR does / why we need it:
Add authentication to GitHub Container Registry to the Prerequisites section in QuickStart Page.
I followed the procedure in QuickStart according to the document, but without GitHub Container Registry authentication, I got the following error, so I added it to the Prerequisites section.
Which issue(s) this PR fixes: no
Fixes #
Does this PR introduce a user-facing change?: no