Skip to content

Conversation

@t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Feb 2, 2024

What this PR does / why we need it:

Replaced AWS SecretManager with AWS Secrets Manager

Which issue(s) this PR fixes: no

Does this PR introduce a user-facing change?: no

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Catch 👍

@codecov
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea9a453) 31.02% compared to head (eab2f31) 31.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4770      +/-   ##
==========================================
+ Coverage   31.02%   31.03%   +0.01%     
==========================================
  Files         225      225              
  Lines       26353    26353              
==========================================
+ Hits         8175     8179       +4     
+ Misses      17525    17521       -4     
  Partials      653      653              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t-kikuc t-kikuc enabled auto-merge (squash) February 5, 2024 05:09
@t-kikuc t-kikuc merged commit 2551594 into master Feb 6, 2024
@t-kikuc t-kikuc deleted the doc-typo-aws-secrets branch February 6, 2024 03:23
@khanhtc1202 khanhtc1202 mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants