Skip to content

Conversation

@ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Jan 17, 2024

What this PR does / why we need it:

Currently, notifications for DEPLOYMENT_ROLLING_BACK is not supported.
See #4547

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@ffjlabo ffjlabo force-pushed the disable-rollback-event-on-docs branch from c2581aa to 14a5051 Compare January 17, 2024 05:08
@codecov
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (624493a) 30.85% compared to head (14a5051) 30.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4751   +/-   ##
=======================================
  Coverage   30.85%   30.85%           
=======================================
  Files         222      222           
  Lines       26037    26037           
=======================================
  Hits         8033     8033           
  Misses      17355    17355           
  Partials      649      649           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kentakozuka kentakozuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch :+\

@ffjlabo ffjlabo changed the title FIx docs about notifications for DEPLOYMENT_ROLLING_BACK Fix docs about notifications for DEPLOYMENT_ROLLING_BACK Jan 17, 2024
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@ffjlabo ffjlabo merged commit 522a13b into master Jan 17, 2024
@ffjlabo ffjlabo deleted the disable-rollback-event-on-docs branch January 17, 2024 07:04
@github-actions github-actions bot mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants