Add RC Release Procedure #4749
Merged
Add RC Release Procedure #4749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: t-kikuc <[email protected]>
t-kikuc
requested review from
ffjlabo,
kentakozuka,
khanhtc1202 and
nghialv
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4749 +/- ##
==========================================
- Coverage 30.88% 30.84% -0.04%
==========================================
Files 222 222
Lines 26037 26037
==========================================
- Hits 8041 8032 -9
- Misses 17347 17356 +9
Partials 649 649 ☔ View full report in Codecov by Sentry. |
ffjlabo
reviewed
Jan 12, 2024
Member
ffjlabo
left a comment
ffjlabo
left a comment
There was a problem hiding this comment.
Nice catch 👍 Added a nit comment.
| Add docs for SCRIPT_RUN stage (#4734) | ||
| ``` | ||
| 2. Classify the changes into 'Notable Changes' and 'Internal Changes'. |
Member
There was a problem hiding this comment.
[nit] How about adding the explanation for 'Notable Changes' and 'Internal Changes' 👀
- Notable Changes
- Changes that should notify users (i.g., new features, breaking changes, etc.)
- Internal Changes
- Changes that don't affect the functions
@khanhtc1202 This is my understanding. Are you aware of it? 👀
Member
There was a problem hiding this comment.
I think those words have mean by itself. But if you want to add definition for those, should be added at other level in this release note file. Say, place of defining versions semantic or such 👀
Member
There was a problem hiding this comment.
I think those words have mean by itself.
@khanhtc1202
Oh I see, I got it. That's right (checked with translator🙏 )
I agree with it 👍 We don't need do that. Thanks!
khanhtc1202
approved these changes
Jan 15, 2024
t-kikuc
added a commit
that referenced
this pull request
Jan 19, 2024
Signed-off-by: t-kikuc <[email protected]>
t-kikuc
added a commit
that referenced
this pull request
Jan 19, 2024
* Add pipectl init command but not implemented Signed-off-by: t-kikuc <[email protected]> * Modify init command Signed-off-by: t-kikuc <[email protected]> * Rename init command to initialize Signed-off-by: t-kikuc <[email protected]> * Create pipectl int for ECS Signed-off-by: t-kikuc <[email protected]> * Add init for ECS Signed-off-by: t-kikuc <[email protected]> * Convert json.RawMessage to struct Signed-off-by: t-kikuc <[email protected]> * Use original structs of ECS for pipectl init Signed-off-by: t-kikuc <[email protected]> * Init k8s app for pipectl init, but not implemented Signed-off-by: t-kikuc <[email protected]> * Fix init input(wip) Signed-off-by: t-kikuc <[email protected]> * Add mock prompt reader Signed-off-by: t-kikuc <[email protected]> * Reractor prompt reader Signed-off-by: t-kikuc <[email protected]> * Modify mock reader to public Signed-off-by: t-kikuc <[email protected]> * Refactored prompt reader Signed-off-by: t-kikuc <[email protected]> * Add yaml snapshot test Signed-off-by: t-kikuc <[email protected]> * Revert "Init k8s app for pipectl init, but not implemented" This reverts commit 4097fb7. Signed-off-by: t-kikuc <[email protected]> * Refactor pipectl init Signed-off-by: t-kikuc <[email protected]> * Remove go-yaml from go.mod Signed-off-by: t-kikuc <[email protected]> * Modify tests to Parallel Signed-off-by: t-kikuc <[email protected]> * Fix reference of loop variable in tests Signed-off-by: t-kikuc <[email protected]> * Enable interruption signal for pipectl init Signed-off-by: t-kikuc <[email protected]> * Add LoadBalancerName to ECS TargetGroup Signed-off-by: t-kikuc <[email protected]> * Use Reader in tests Signed-off-by: t-kikuc <[email protected]> * Remove stdinReader Signed-off-by: t-kikuc <[email protected]> * Remove mockReader Signed-off-by: t-kikuc <[email protected]> * Add Prompt and PromptInput types Signed-off-by: t-kikuc <[email protected]> * Remove promptReader Signed-off-by: t-kikuc <[email protected]> * Refactored init,exporter Signed-off-by: t-kikuc <[email protected]> * Update Copyright Signed-off-by: t-kikuc <[email protected]> * Refactored nits Signed-off-by: t-kikuc <[email protected]> * Add reference to the blog that shows how to install control plane on ECS (#4746) Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: t-kikuc <[email protected]> * Bump follow-redirects from 1.15.2 to 1.15.4 in /web (#4747) Signed-off-by: t-kikuc <[email protected]> * Add RC Release Procedure (#4749) Signed-off-by: t-kikuc <[email protected]> * Fix nits Signed-off-by: t-kikuc <[email protected]> * Fix error variable name Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: Yoshiki Fujikane <[email protected]> Co-authored-by: Yoshiki Fujikane <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
nnnkkk7
pushed a commit
to nnnkkk7/pipecd
that referenced
this pull request
Feb 1, 2024
Signed-off-by: t-kikuc <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?: