Skip to content

Conversation

@minhquang4334
Copy link
Contributor

What this PR does / why we need it:
io/ioutil package is deprecated, use corresponding 'os' package instead.

refs: https://pkg.go.dev/io/ioutil#ReadFile

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@khanhtc1202 khanhtc1202 enabled auto-merge (squash) December 26, 2023 12:57
@codecov
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (301e367) 30.82% compared to head (ab84dd2) 30.82%.
Report is 19 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4742   +/-   ##
=======================================
  Coverage   30.82%   30.82%           
=======================================
  Files         221      221           
  Lines       25993    26015   +22     
=======================================
+ Hits         8012     8019    +7     
- Misses      17331    17346   +15     
  Partials      650      650           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@khanhtc1202 khanhtc1202 merged commit 26f8ecb into pipe-cd:master Dec 27, 2023
nnnkkk7 pushed a commit to nnnkkk7/pipecd that referenced this pull request Feb 1, 2024
@github-actions github-actions bot mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants