Fix typo in the example of ECS Service Discovery #4735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: t-kikuc <[email protected]>
t-kikuc
requested review from
ffjlabo,
kentakozuka,
khanhtc1202 and
nghialv
as code owners
Signed-off-by: t-kikuc <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4735 +/- ##
=======================================
Coverage 30.83% 30.83%
=======================================
Files 221 221
Lines 26015 26015
=======================================
Hits 8023 8023
Misses 17342 17342
Partials 650 650 ☔ View full report in Codecov by Sentry. |
khanhtc1202
approved these changes
Dec 22, 2023
ffjlabo
approved these changes
Dec 25, 2023
t-kikuc
added a commit
that referenced
this pull request
Dec 26, 2023
* Fix description in the example of ECS Service Discovery Signed-off-by: t-kikuc <[email protected]> * Remove a blank line in the doc Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]>
nnnkkk7
pushed a commit
to nnnkkk7/pipecd
that referenced
this pull request
Feb 1, 2024
* Fix description in the example of ECS Service Discovery Signed-off-by: t-kikuc <[email protected]> * Remove a blank line in the doc Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: