Skip to content

Conversation

@hungran
Copy link
Contributor

@hungran hungran commented Dec 14, 2023

What this PR does / why we need it: fix last PR ##4712
apologized for my last PR did not deep check test
This PR will introduce exclude and update docker build and push action to v5.0.0 on all flows

image

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?: n/a

  • How are users affected by this change: n/a
  • Is this breaking change: n/a
  • How to migrate (if breaking change): n/a

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 🐰

@hungran hungran marked this pull request as ready for review December 14, 2023 04:47
@codecov
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (31137ec) 30.82% compared to head (fd8ce28) 30.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4718      +/-   ##
==========================================
+ Coverage   30.82%   30.84%   +0.02%     
==========================================
  Files         221      221              
  Lines       25993    25993              
==========================================
+ Hits         8012     8018       +6     
+ Misses      17331    17325       -6     
  Partials      650      650              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khanhtc1202 khanhtc1202 enabled auto-merge (squash) December 14, 2023 05:11
Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for refactoring 🙏

@khanhtc1202 khanhtc1202 merged commit 2035225 into pipe-cd:master Dec 14, 2023
sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Dec 17, 2023
sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Dec 17, 2023
sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Dec 17, 2023
@github-actions github-actions bot mentioned this pull request Feb 6, 2024
sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants