Skip to content

Conversation

@ouchi2501
Copy link
Contributor

What this PR does / why we need it:

  • By specifying gpt-4-1106-preview as the model for code-butler, PRs with many differences can be reviewed at once.
  • However, since OpenAI's paid plan Token is required, you need to update your Token before Merge this PR.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@ffjlabo
Copy link
Member

ffjlabo commented Dec 13, 2023

/review

@github-actions
Copy link
Contributor

PR Analysis

Main theme

Adding a new model parameter to the GitHub Actions workflow file.

PR summary

This PR adds a new parameter `model` to the GitHub Actions workflow file `code-butler.yaml`. The parameter allows specifying the model to be used for code review and chat commands in the workflow.

Type of PR

Enhancement

PR Feedback:

General suggestions

It would be helpful to provide a brief explanation in the code comments about the purpose of the `model` parameter and how it should be used.

Code feedback

- File: .github/workflows/code-butler.yaml
  - Line: 21
    - Suggestion: Add a code comment explaining the purpose and usage of the `model` parameter.

- File: .github/workflows/code-butler.yaml
  - Line: 31
    - Suggestion: Add a code comment explaining the purpose and usage of the `model` parameter.

Security concerns:

No

@codecov
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (99ba372) 30.82% compared to head (135b481) 30.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4714   +/-   ##
=======================================
  Coverage   30.82%   30.83%           
=======================================
  Files         221      221           
  Lines       25993    25993           
=======================================
+ Hits         8012     8014    +2     
+ Misses      17331    17329    -2     
  Partials      650      650           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ouchi2501 ouchi2501 force-pushed the add-model-code-butler branch from 70fe2f3 to 135b481 Compare December 13, 2023 07:38
@ffjlabo
Copy link
Member

ffjlabo commented Dec 13, 2023

@ouchi2501
updated our OpenAI token and it looks work 👍

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@khanhtc1202 khanhtc1202 merged commit 4396fb7 into pipe-cd:master Dec 13, 2023
@ouchi2501 ouchi2501 deleted the add-model-code-butler branch December 14, 2023 01:17
sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Dec 17, 2023
sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Dec 17, 2023
sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Dec 17, 2023
@github-actions github-actions bot mentioned this pull request Feb 6, 2024
sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants