Add setValues to HelmOptions #4699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golemiso
requested review from
ffjlabo,
kentakozuka,
khanhtc1202 and
nghialv
as code owners
Member
|
@golemiso Nice improvement! Thank so much for the PR 🙌 Could you sign off the commit using |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4699 +/- ##
==========================================
- Coverage 30.86% 30.81% -0.06%
==========================================
Files 221 221
Lines 25975 25987 +12
==========================================
- Hits 8018 8008 -10
- Misses 17307 17328 +21
- Partials 650 651 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: golemiso <[email protected]>
khanhtc1202
approved these changes
Dec 7, 2023
Member
khanhtc1202
left a comment
khanhtc1202
left a comment
There was a problem hiding this comment.
Nice improvement, thanks 🙌
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Dec 17, 2023
Signed-off-by: golemiso <[email protected]>
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Dec 17, 2023
Signed-off-by: golemiso <[email protected]>
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Dec 17, 2023
Signed-off-by: golemiso <[email protected]> Signed-off-by: sZma5a <[email protected]>
Merged
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Feb 12, 2024
Signed-off-by: golemiso <[email protected]> Signed-off-by: 鈴木 優耀 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To make it easier to configure helm
Which issue(s) this PR fixes:
N/A
Does this PR introduce a user-facing change?: