[ECS] Tag to the new taskset in rollback (fixes #4692) #4695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: t-kikuc <[email protected]>
t-kikuc
requested review from
ffjlabo,
kentakozuka,
khanhtc1202 and
nghialv
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4695 +/- ##
==========================================
+ Coverage 30.84% 30.86% +0.02%
==========================================
Files 221 221
Lines 25975 25975
==========================================
+ Hits 8012 8018 +6
+ Misses 17313 17307 -6
Partials 650 650 ☔ View full report in Codecov by Sentry. |
Signed-off-by: t-kikuc <[email protected]>
t-kikuc
changed the title
Merged
khanhtc1202
pushed a commit
that referenced
this pull request
Dec 1, 2023
* Tag to new taskset in rollback Signed-off-by: t-kikuc <[email protected]> * Fix #4692 (ECS excess tasksets) Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]>
khanhtc1202
added a commit
that referenced
this pull request
Dec 1, 2023
* add ephemeralStorage option to lambda config (#4680) * add ephemeralStorage option to lambda config Signed-off-by: nnnkkk7 <[email protected]> Signed-off-by: nnnkkk7 <[email protected]> * add nil pointer check Signed-off-by: nnnkkk7 <[email protected]> * add EphemeralStorage input to CreateFunctionFromSource Signed-off-by: nnnkkk7 <[email protected]> * fix condition Signed-off-by: nnnkkk7 <[email protected]> --------- Signed-off-by: nnnkkk7 <[email protected]> * Add v2 to versionWhitelist (#4682) Signed-off-by: Yoshiki Fujikane <[email protected]> * [ECS] Tag to the new taskset in rollback (fixes #4692) (#4695) * Tag to new taskset in rollback Signed-off-by: t-kikuc <[email protected]> * Fix #4692 (ECS excess tasksets) Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: nnnkkk7 <[email protected]> Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: t-kikuc <[email protected]> Co-authored-by: naoki kuroda <[email protected]> Co-authored-by: Yoshiki Fujikane <[email protected]> Co-authored-by: Tetsuya Kikuchi <[email protected]>
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Dec 17, 2023
…d#4695) * Tag to new taskset in rollback Signed-off-by: t-kikuc <[email protected]> * Fix pipe-cd#4692 (ECS excess tasksets) Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]>
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Dec 17, 2023
…d#4695) * Tag to new taskset in rollback Signed-off-by: t-kikuc <[email protected]> * Fix pipe-cd#4692 (ECS excess tasksets) Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]>
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Dec 17, 2023
…d#4695) * Tag to new taskset in rollback Signed-off-by: t-kikuc <[email protected]> * Fix pipe-cd#4692 (ECS excess tasksets) Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: sZma5a <[email protected]>
Merged
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Feb 12, 2024
…d#4695) * Tag to new taskset in rollback Signed-off-by: t-kikuc <[email protected]> * Fix pipe-cd#4692 (ECS excess tasksets) Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: 鈴木 優耀 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #4692
Does this PR introduce a user-facing change?: no