[Draft] Add ECS Service Discovery funcs

[t-kikuc]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Part of #4616

Does this PR introduce a user-facing change?:

• How are users affected by this change:
• Is this breaking change:
• How to migrate (if breaking change):

[codecov]

Codecov Report

Attention: 62 lines in your changes are missing coverage. Please review.

Comparison is base (8a4235b) 30.82% compared to head (c8ed0ad) 30.76%.
Report is 1 commits behind head on master.

❗ Current head c8ed0ad differs from pull request most recent head d52349d. Consider uploading reports for the commit d52349d to get more accurate results

Files	Patch %	Lines
pkg/app/piped/platformprovider/ecs/client.go	0.00%	62 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4681      +/-   ##
==========================================
- Coverage   30.82%   30.76%   -0.06%     
==========================================
  Files         221      221              
  Lines       25935    25997      +62     
==========================================
+ Hits         7995     7999       +4     
- Misses      17289    17348      +59     
+ Partials      651      650       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kentakozuka]

/review

[github-actions]

PR Analysis

Main theme

The main theme of this PR is to update dependencies in the project's go.mod file.

PR summary

This PR updates several dependencies in the go.mod file, including the github.com/aws/aws-sdk-go-v2 package.

Type of PR

Enhancement

PR Feedback:

General suggestions

This PR appears to be straightforward and achieves the desired goal of updating dependencies. It is always beneficial to keep project dependencies up to date to ensure compatibility and security. Good job!

Code feedback

go.mod

• Line 13: +github.com/aws/aws-sdk-go-v2 v1.23.0
  • This line introduces a new version of the github.com/aws/aws-sdk-go-v2 package. No issues or improvements identified.
• Line 23: +github.com/aws/aws-sdk-go-v2/service/servicediscovery v1.26.2
  • This line introduces a new version of the github.com/aws/aws-sdk-go-v2/service/servicediscovery package. No issues or improvements identified.
• Line 27: +github.com/aws/aws-sdk-go-v2/internal/configsources v1.2.3 // indirect
  • This line introduces a new version of the github.com/aws/aws-sdk-go-v2/internal/configsources package. No issues or improvements identified.
• Line 28: +github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.5.3 // indirect
  • This line introduces a new version of the github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 package. No issues or improvements identified.
• Line 94: +github.com/aws/smithy-go v1.17.0 // indirect
  • This line introduces a new version of the github.com/aws/smithy-go package. No issues or improvements identified.

Security concerns:

No

[github-actions]

PR Analysis

Main theme

Bug fix

PR summary

This PR updates the version of the aws-sdk-go-v2 dependency from v1.17.7 to v1.23.0. It also updates the version of the aws-sdk-go-v2 dependency in the go.mod file.

Type of PR

Bug fix

PR Feedback:

General suggestions

It's good practice to keep dependencies updated to ensure the latest features and bug fixes are available. Great job on updating the aws-sdk-go-v2 dependency.

Code feedback

File: go.sum

Suggestion 1 (important)

The new version of github.com/aws/aws-sdk-go-v2 dependency has been updated correctly in the go.sum file.

github.com/aws/aws-sdk-go-v2 v1.23.0 h1:PiHAzmiQQr6JULBUdvR8fKlA+UPKLT/8KbiqpFBWiAo=
github.com/aws/aws-sdk-go-v2 v1.23.0/go.mod h1:i1XDttT4rnf6vxc9AuskLc6s7XBee8rlLilKlc03uAA=

Suggestion 2 (medium)

The github.com/aws/aws-sdk-go-v2 dependency appears multiple times in the go.sum file. It is recommended to remove the old versions of the dependency to avoid confusion and potential conflicts in the future.

 github.com/aws/aws-sdk-go-v2 v1.17.7 h1:CLSjnhJSTSogvqUGhIC6LqFKATMRexcxLZ0i/Nzk9Eg=
 github.com/aws/aws-sdk-go-v2 v1.17.7/go.mod h1:uzbQtefpm44goOPmdKyAlXSNcwlRgF3ePWVW6EtJvvw=
 ...
-github.com/aws/aws-sdk-go-v2 v2.5.3 h1:AplLJCtIaUZDCbr6+gLYdsYNxne4iuaboJhVt9d+WXI=
-github.com/aws/aws-sdk-go-v2 v2.5.3/go.mod h1:ify42Rb7nKeDDPkFjKn7q1bPscVPu/+gmHH8d2c+anU=
 ...
+github.com/aws/aws-sdk-go-v2 v1.23.0 h1:PiHAzmiQQr6JULBUdvR8fKlA+UPKLT/8KbiqpFBWiAo=
+github.com/aws/aws-sdk-go-v2 v1.23.0/go.mod h1:i1XDttT4rnf6vxc9AuskLc6s7XBee8rlLilKlc03uAA=

File: go.mod

Suggestion 3 (important)

The new version of github.com/aws/aws-sdk-go-v2 dependency has been updated correctly in the go.mod file.

github.com/aws/aws-sdk-go-v2 v1.23.0/go.mod h1:i1XDttT4rnf6vxc9AuskLc6s7XBee8rlLilKlc03uAA=

Suggestion 4 (medium)

The github.com/aws/aws-sdk-go-v2 dependency appears multiple times in the go.mod file. It is recommended to remove the old versions of the dependency to avoid confusion and potential conflicts in the future.

 module example.com/my-module

 go 1.16

 require (
 ...
 github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream v1.4.10/go.mod h1:VeTZetY5KRJLuD/7fkQXMU6Mw7H5m/KP2J5Iy9osMno=
 github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream v1.11.0/go.mod h1:mqqj6Q74ubD7lEqtf9Ge2gZrxJXmiJHOop6c9mfuPO4=
 ...
 github.com/aws/aws-sdk-go-v2/service/sso v1.12.6/go.mod h1:Y1VOmit/Fn6Tz1uFAeCO6Q7M2fmfXSCLeL5INVYs

[github-actions]

PR Analysis

Main theme

The main theme of this PR is to add functionality for interacting with the AWS ECS service discovery in the ECS client.

PR summary

This PR adds methods to the client struct in the client.go file to register and deregister EC2 instances with AWS ECS service discovery. It also includes helper methods to extract information such as the cluster ARN and the private IPv4 address of an ECS task.

Type of PR

Enhancement

PR Feedback:

General suggestions

It would be helpful to include some comments or docstrings to explain the purpose and usage of the newly added methods and helper functions. This will improve the readability and maintainability of the code.

Code feedback

pkg/app/piped/platformprovider/ecs/client.go:49

The sdClient field of the client struct is not being used in this code file. It would be better to remove the unused field to avoid confusion.

pkg/app/piped/platformprovider/ecs/client.go:49

It would be beneficial to include a comment above the client struct to explain the purpose and responsibilities of this struct.

pkg/app/piped/platformprovider/ecs/client.go:79

Consider adding error handling for potential errors that may occur when creating the servicediscovery.Client. For example, if an error occurs when creating the client, it may be useful to return an error instead of nil in the newClient function.

pkg/app/piped/platformprovider/ecs/client.go:491

Consider adding error handling for potential errors that may occur when calling DescribeTasks and when retrieving the private IPv4 address of the task. Proper error handling will provide more useful information in case of failures.

pkg/app/piped/platformprovider/ecs/client.go:508

Consider adding error handling for potential errors that may occur when calling RegisterInstance. Proper error handling will provide more useful information in case of failures.

Security concerns:

No

[t-kikuc]

I closed this PR because PR #4685 is better to merge.