Add docs for k8s annotations #4673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoshiki Fujikane <[email protected]>
ffjlabo
requested review from
kentakozuka,
khanhtc1202 and
nghialv
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4673 +/- ##
=======================================
Coverage 30.81% 30.82%
=======================================
Files 221 221
Lines 25935 25935
=======================================
+ Hits 7993 7995 +2
+ Misses 17292 17290 -2
Partials 650 650 ☔ View full report in Codecov by Sentry. |
moko-poi
pushed a commit
to moko-poi/pipecd
that referenced
this pull request
Nov 15, 2023
Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: moko-poi <[email protected]>
khanhtc1202
added a commit
that referenced
this pull request
Nov 28, 2023
* feat(ECS): enable selection of listener rules Signed-off-by: moko-poi <[email protected]> * Update pkg/app/piped/platformprovider/ecs/client.go Signed-off-by: moko-poi <[email protected]> * Make actions plan preview handle timeout option (#4648) * Format and make tests pass in tool/actions-plan-preview Signed-off-by: mi11km <[email protected]> * Use --piped-handle-timeout to make the timeout arg activate Signed-off-by: mi11km <[email protected]> * Add tests to model/notificationevent (#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <[email protected]> * Add Parallel() Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: mi11km <[email protected]> * add piped-handle-timeout(input args) Signed-off-by: mi11km <[email protected]> --------- Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: moko-poi <[email protected]> * Increase limit of stale action operations (#4671) Signed-off-by: moko-poi <[email protected]> * Add docs for k8s annotations (#4673) Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: moko-poi <[email protected]> * feat: add modifylisner and modifyrule Signed-off-by: moko-poi <[email protected]> * fix: ModifyRules Signed-off-by: moko-poi <[email protected]> * fix: rollback Signed-off-by: moko-poi <[email protected]> * fix: routing Signed-off-by: moko-poi <[email protected]> * fix: action.Type == elbtypes.ActionTypeEnumForward Signed-off-by: moko-poi <[email protected]> * fix: Update ModifyListeners and ModifyRules for Selective Action Modification Signed-off-by: moko-poi <[email protected]> --------- Signed-off-by: moko-poi <[email protected]> Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: Yoshiki Fujikane <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: Masafumi Ikeyama <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Yoshiki Fujikane <[email protected]>
khanhtc1202
added a commit
that referenced
this pull request
Nov 28, 2023
* feat(ECS): enable selection of listener rules Signed-off-by: moko-poi <[email protected]> * Update pkg/app/piped/platformprovider/ecs/client.go Signed-off-by: moko-poi <[email protected]> * Make actions plan preview handle timeout option (#4648) * Format and make tests pass in tool/actions-plan-preview Signed-off-by: mi11km <[email protected]> * Use --piped-handle-timeout to make the timeout arg activate Signed-off-by: mi11km <[email protected]> * Add tests to model/notificationevent (#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <[email protected]> * Add Parallel() Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: mi11km <[email protected]> * add piped-handle-timeout(input args) Signed-off-by: mi11km <[email protected]> --------- Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: moko-poi <[email protected]> * Increase limit of stale action operations (#4671) Signed-off-by: moko-poi <[email protected]> * Add docs for k8s annotations (#4673) Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: moko-poi <[email protected]> * feat: add modifylisner and modifyrule Signed-off-by: moko-poi <[email protected]> * fix: ModifyRules Signed-off-by: moko-poi <[email protected]> * fix: rollback Signed-off-by: moko-poi <[email protected]> * fix: routing Signed-off-by: moko-poi <[email protected]> * fix: action.Type == elbtypes.ActionTypeEnumForward Signed-off-by: moko-poi <[email protected]> * fix: Update ModifyListeners and ModifyRules for Selective Action Modification Signed-off-by: moko-poi <[email protected]> --------- Signed-off-by: moko-poi <[email protected]> Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: Yoshiki Fujikane <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: Masafumi Ikeyama <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Yoshiki Fujikane <[email protected]>
khanhtc1202
added a commit
that referenced
this pull request
Nov 28, 2023
* feat(ECS): enable selection of listener rules (#4668) * feat(ECS): enable selection of listener rules Signed-off-by: moko-poi <[email protected]> * Update pkg/app/piped/platformprovider/ecs/client.go Signed-off-by: moko-poi <[email protected]> * Make actions plan preview handle timeout option (#4648) * Format and make tests pass in tool/actions-plan-preview Signed-off-by: mi11km <[email protected]> * Use --piped-handle-timeout to make the timeout arg activate Signed-off-by: mi11km <[email protected]> * Add tests to model/notificationevent (#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <[email protected]> * Add Parallel() Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: mi11km <[email protected]> * add piped-handle-timeout(input args) Signed-off-by: mi11km <[email protected]> --------- Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: moko-poi <[email protected]> * Increase limit of stale action operations (#4671) Signed-off-by: moko-poi <[email protected]> * Add docs for k8s annotations (#4673) Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: moko-poi <[email protected]> * feat: add modifylisner and modifyrule Signed-off-by: moko-poi <[email protected]> * fix: ModifyRules Signed-off-by: moko-poi <[email protected]> * fix: rollback Signed-off-by: moko-poi <[email protected]> * fix: routing Signed-off-by: moko-poi <[email protected]> * fix: action.Type == elbtypes.ActionTypeEnumForward Signed-off-by: moko-poi <[email protected]> * fix: Update ModifyListeners and ModifyRules for Selective Action Modification Signed-off-by: moko-poi <[email protected]> --------- Signed-off-by: moko-poi <[email protected]> Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: Yoshiki Fujikane <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: Masafumi Ikeyama <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Yoshiki Fujikane <[email protected]> * Remove ModifyRules interface (#4688) --------- Signed-off-by: moko-poi <[email protected]> Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: Yoshiki Fujikane <[email protected]> Co-authored-by: Shun Takahashi <[email protected]> Co-authored-by: Masafumi Ikeyama <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Yoshiki Fujikane <[email protected]>
Merged
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Dec 17, 2023
Signed-off-by: Yoshiki Fujikane <[email protected]>
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Dec 17, 2023
* feat(ECS): enable selection of listener rules Signed-off-by: moko-poi <[email protected]> * Update pkg/app/piped/platformprovider/ecs/client.go Signed-off-by: moko-poi <[email protected]> * Make actions plan preview handle timeout option (pipe-cd#4648) * Format and make tests pass in tool/actions-plan-preview Signed-off-by: mi11km <[email protected]> * Use --piped-handle-timeout to make the timeout arg activate Signed-off-by: mi11km <[email protected]> * Add tests to model/notificationevent (pipe-cd#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <[email protected]> * Add Parallel() Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: mi11km <[email protected]> * add piped-handle-timeout(input args) Signed-off-by: mi11km <[email protected]> --------- Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: moko-poi <[email protected]> * Increase limit of stale action operations (pipe-cd#4671) Signed-off-by: moko-poi <[email protected]> * Add docs for k8s annotations (pipe-cd#4673) Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: moko-poi <[email protected]> * feat: add modifylisner and modifyrule Signed-off-by: moko-poi <[email protected]> * fix: ModifyRules Signed-off-by: moko-poi <[email protected]> * fix: rollback Signed-off-by: moko-poi <[email protected]> * fix: routing Signed-off-by: moko-poi <[email protected]> * fix: action.Type == elbtypes.ActionTypeEnumForward Signed-off-by: moko-poi <[email protected]> * fix: Update ModifyListeners and ModifyRules for Selective Action Modification Signed-off-by: moko-poi <[email protected]> --------- Signed-off-by: moko-poi <[email protected]> Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: Yoshiki Fujikane <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: Masafumi Ikeyama <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Yoshiki Fujikane <[email protected]>
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Dec 17, 2023
Signed-off-by: Yoshiki Fujikane <[email protected]>
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Dec 17, 2023
* feat(ECS): enable selection of listener rules Signed-off-by: moko-poi <[email protected]> * Update pkg/app/piped/platformprovider/ecs/client.go Signed-off-by: moko-poi <[email protected]> * Make actions plan preview handle timeout option (pipe-cd#4648) * Format and make tests pass in tool/actions-plan-preview Signed-off-by: mi11km <[email protected]> * Use --piped-handle-timeout to make the timeout arg activate Signed-off-by: mi11km <[email protected]> * Add tests to model/notificationevent (pipe-cd#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <[email protected]> * Add Parallel() Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: mi11km <[email protected]> * add piped-handle-timeout(input args) Signed-off-by: mi11km <[email protected]> --------- Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: moko-poi <[email protected]> * Increase limit of stale action operations (pipe-cd#4671) Signed-off-by: moko-poi <[email protected]> * Add docs for k8s annotations (pipe-cd#4673) Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: moko-poi <[email protected]> * feat: add modifylisner and modifyrule Signed-off-by: moko-poi <[email protected]> * fix: ModifyRules Signed-off-by: moko-poi <[email protected]> * fix: rollback Signed-off-by: moko-poi <[email protected]> * fix: routing Signed-off-by: moko-poi <[email protected]> * fix: action.Type == elbtypes.ActionTypeEnumForward Signed-off-by: moko-poi <[email protected]> * fix: Update ModifyListeners and ModifyRules for Selective Action Modification Signed-off-by: moko-poi <[email protected]> --------- Signed-off-by: moko-poi <[email protected]> Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: Yoshiki Fujikane <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: Masafumi Ikeyama <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Yoshiki Fujikane <[email protected]>
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Dec 17, 2023
Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: sZma5a <[email protected]>
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Dec 17, 2023
* feat(ECS): enable selection of listener rules Signed-off-by: moko-poi <[email protected]> * Update pkg/app/piped/platformprovider/ecs/client.go Signed-off-by: moko-poi <[email protected]> * Make actions plan preview handle timeout option (pipe-cd#4648) * Format and make tests pass in tool/actions-plan-preview Signed-off-by: mi11km <[email protected]> * Use --piped-handle-timeout to make the timeout arg activate Signed-off-by: mi11km <[email protected]> * Add tests to model/notificationevent (pipe-cd#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <[email protected]> * Add Parallel() Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: mi11km <[email protected]> * add piped-handle-timeout(input args) Signed-off-by: mi11km <[email protected]> --------- Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: moko-poi <[email protected]> * Increase limit of stale action operations (pipe-cd#4671) Signed-off-by: moko-poi <[email protected]> * Add docs for k8s annotations (pipe-cd#4673) Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: moko-poi <[email protected]> * feat: add modifylisner and modifyrule Signed-off-by: moko-poi <[email protected]> * fix: ModifyRules Signed-off-by: moko-poi <[email protected]> * fix: rollback Signed-off-by: moko-poi <[email protected]> * fix: routing Signed-off-by: moko-poi <[email protected]> * fix: action.Type == elbtypes.ActionTypeEnumForward Signed-off-by: moko-poi <[email protected]> * fix: Update ModifyListeners and ModifyRules for Selective Action Modification Signed-off-by: moko-poi <[email protected]> --------- Signed-off-by: moko-poi <[email protected]> Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: Yoshiki Fujikane <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: Masafumi Ikeyama <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Yoshiki Fujikane <[email protected]> Signed-off-by: sZma5a <[email protected]>
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Dec 17, 2023
* feat(ECS): enable selection of listener rules Signed-off-by: moko-poi <[email protected]> * Update pkg/app/piped/platformprovider/ecs/client.go Signed-off-by: moko-poi <[email protected]> * Make actions plan preview handle timeout option (pipe-cd#4648) * Format and make tests pass in tool/actions-plan-preview Signed-off-by: mi11km <[email protected]> * Use --piped-handle-timeout to make the timeout arg activate Signed-off-by: mi11km <[email protected]> * Add tests to model/notificationevent (pipe-cd#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <[email protected]> * Add Parallel() Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: mi11km <[email protected]> * add piped-handle-timeout(input args) Signed-off-by: mi11km <[email protected]> --------- Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: moko-poi <[email protected]> * Increase limit of stale action operations (pipe-cd#4671) Signed-off-by: moko-poi <[email protected]> * Add docs for k8s annotations (pipe-cd#4673) Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: moko-poi <[email protected]> * feat: add modifylisner and modifyrule Signed-off-by: moko-poi <[email protected]> * fix: ModifyRules Signed-off-by: moko-poi <[email protected]> * fix: rollback Signed-off-by: moko-poi <[email protected]> * fix: routing Signed-off-by: moko-poi <[email protected]> * fix: action.Type == elbtypes.ActionTypeEnumForward Signed-off-by: moko-poi <[email protected]> * fix: Update ModifyListeners and ModifyRules for Selective Action Modification Signed-off-by: moko-poi <[email protected]> --------- Signed-off-by: moko-poi <[email protected]> Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: Yoshiki Fujikane <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: Masafumi Ikeyama <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Yoshiki Fujikane <[email protected]> Signed-off-by: sZma5a <[email protected]>
Merged
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Feb 12, 2024
Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: 鈴木 優耀 <[email protected]>
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Feb 12, 2024
* feat(ECS): enable selection of listener rules Signed-off-by: moko-poi <[email protected]> * Update pkg/app/piped/platformprovider/ecs/client.go Signed-off-by: moko-poi <[email protected]> * Make actions plan preview handle timeout option (pipe-cd#4648) * Format and make tests pass in tool/actions-plan-preview Signed-off-by: mi11km <[email protected]> * Use --piped-handle-timeout to make the timeout arg activate Signed-off-by: mi11km <[email protected]> * Add tests to model/notificationevent (pipe-cd#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <[email protected]> * Add Parallel() Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: mi11km <[email protected]> * add piped-handle-timeout(input args) Signed-off-by: mi11km <[email protected]> --------- Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: moko-poi <[email protected]> * Increase limit of stale action operations (pipe-cd#4671) Signed-off-by: moko-poi <[email protected]> * Add docs for k8s annotations (pipe-cd#4673) Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: moko-poi <[email protected]> * feat: add modifylisner and modifyrule Signed-off-by: moko-poi <[email protected]> * fix: ModifyRules Signed-off-by: moko-poi <[email protected]> * fix: rollback Signed-off-by: moko-poi <[email protected]> * fix: routing Signed-off-by: moko-poi <[email protected]> * fix: action.Type == elbtypes.ActionTypeEnumForward Signed-off-by: moko-poi <[email protected]> * fix: Update ModifyListeners and ModifyRules for Selective Action Modification Signed-off-by: moko-poi <[email protected]> --------- Signed-off-by: moko-poi <[email protected]> Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: Yoshiki Fujikane <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: Masafumi Ikeyama <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Yoshiki Fujikane <[email protected]> Signed-off-by: 鈴木 優耀 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Some annotations for k8s resources are not described in official docs. So I added docs.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: