Skip to content

Fix unable to fetch ECS taskset tags #4605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khanhtc1202 merged 1 commit into from
Oct 6, 2023
Merged

Fix unable to fetch ECS taskset tags #4605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 26 additions & 3 deletions pkg/app/piped/platformprovider/ecs/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@ func (c *client) CreateTaskSet(ctx context.Context, service types.Service, taskD
if taskDefinition.TaskDefinitionArn == nil {
return nil, fmt.Errorf("failed to create task set of task family %s: no task definition provided", *taskDefinition.Family)
}

input := &ecs.CreateTaskSetInput{
Cluster: service.ClusterArn,
Service: service.ServiceArn,
Expand Down Expand Up @@ -266,16 +267,38 @@ func (c *client) GetServiceTaskSets(ctx context.Context, service types.Service)
return nil, fmt.Errorf("failed to get task sets of service %s: services empty", *service.ServiceName)
}
svc := output.Services[0]
taskSets := make([]*types.TaskSet, 0, len(svc.TaskSets))
activeTaskSetArns := make([]string, 0, len(svc.TaskSets))
for i := range svc.TaskSets {
if aws.ToString(svc.TaskSets[i].Status) == "DRAINING" {
continue
}
if !IsPipeCDManagedTaskSet(&svc.TaskSets[i]) {
activeTaskSetArns = append(activeTaskSetArns, *svc.TaskSets[i].TaskSetArn)
}

if len(activeTaskSetArns) == 0 {
return nil, fmt.Errorf("failed to get task sets of service %s: services empty", *service.ServiceName)
}

tsInput := &ecs.DescribeTaskSetsInput{
Cluster: service.ClusterArn,
Service: service.ServiceArn,
TaskSets: activeTaskSetArns,
Include: []types.TaskSetField{
types.TaskSetFieldTags,
},
}
tsOutput, err := c.ecsClient.DescribeTaskSets(ctx, tsInput)
if err != nil {
return nil, fmt.Errorf("failed to get task sets of service %s: %w", *service.ServiceName, err)
}
taskSets := make([]*types.TaskSet, 0, len(tsOutput.TaskSets))
for i := range tsOutput.TaskSets {
if !IsPipeCDManagedTaskSet(&tsOutput.TaskSets[i]) {
continue
}
taskSets = append(taskSets, &svc.TaskSets[i])
taskSets = append(taskSets, &tsOutput.TaskSets[i])
}

return taskSets, nil
}

Expand Down