Enable to specific image tag for container images in Helm template #4586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent or difference registry Signed-off-by: hungran <[email protected]>
Signed-off-by: hungran <[email protected]>
hungran
requested review from
kentakozuka,
khanhtc1202 and
nghialv
as code owners
khanhtc1202
reviewed
Sep 4, 2023
Member
khanhtc1202
left a comment
khanhtc1202
left a comment
There was a problem hiding this comment.
Great improvement, left some nits 🙏
manifests/pipecd/values.yaml
Outdated
Comment on lines
33
to
34
| # Overrides the image tag whose default is the chart appVersion. | ||
| tag: "" |
Member
There was a problem hiding this comment.
As mentioned in template file, this config should be under image block (same as repository)
manifests/pipecd/values.yaml
Outdated
Comment on lines
56
to
57
| # Overrides the image tag whose default is the chart appVersion. | ||
| tag: "" |
Signed-off-by: hungran <[email protected]>
Contributor
Author
|
@khanhtc1202 thanks for your feedback, solved |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #4586 +/- ##
=======================================
Coverage 29.93% 29.93%
=======================================
Files 220 220
Lines 25933 25933
=======================================
Hits 7763 7763
Misses 17522 17522
Partials 648 648 ☔ View full report in Codecov by Sentry. |
khanhtc1202
changed the title
khanhtc1202
pushed a commit
that referenced
this pull request
Sep 6, 2023
…4586) * ability and flexible for using specific image tag from local environment or difference registry Signed-off-by: hungran <[email protected]> * nist Signed-off-by: hungran <[email protected]> * nist on values pipecd Signed-off-by: hungran <[email protected]> --------- Signed-off-by: hungran <[email protected]>
khanhtc1202
added a commit
that referenced
this pull request
Sep 6, 2023
* Enable to specific image tag for container images in Helm template (#4586) * ability and flexible for using specific image tag from local environment or difference registry Signed-off-by: hungran <[email protected]> * nist Signed-off-by: hungran <[email protected]> * nist on values pipecd Signed-off-by: hungran <[email protected]> --------- Signed-off-by: hungran <[email protected]> * Inactive task definition after delete all of its taskset (#4592) * Store taskSet object instead of taskSetArn Signed-off-by: khanhtc1202 <[email protected]> * Remove service object store in stage metastore Signed-off-by: khanhtc1202 <[email protected]> * Inactive task definition after delete its taskset Signed-off-by: khanhtc1202 <[email protected]> * Update pkg/app/piped/executor/ecs/ecs.go Co-authored-by: Kenta Kozuka <[email protected]> Signed-off-by: khanhtc1202 <[email protected]> --------- Signed-off-by: khanhtc1202 <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: hungran <[email protected]> Signed-off-by: khanhtc1202 <[email protected]> Co-authored-by: Henry Vu <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]>
moko-poi
pushed a commit
to moko-poi/pipecd
that referenced
this pull request
Nov 3, 2023
…ipe-cd#4586) * ability and flexible for using specific image tag from local environment or difference registry Signed-off-by: hungran <[email protected]> * nist Signed-off-by: hungran <[email protected]> * nist on values pipecd Signed-off-by: hungran <[email protected]> --------- Signed-off-by: hungran <[email protected]> Signed-off-by: moko-poi <[email protected]>
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Nov 5, 2023
…ipe-cd#4586) * ability and flexible for using specific image tag from local environment or difference registry Signed-off-by: hungran <[email protected]> * nist Signed-off-by: hungran <[email protected]> * nist on values pipecd Signed-off-by: hungran <[email protected]> --------- Signed-off-by: hungran <[email protected]>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like we have a way to specific an image tag whenever I or somebody else want to test with new OCI image from local environment or difference registry
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #4506
Does this PR introduce a user-facing change?: N/A