Skip to content

Support update service which contains serviceRegistries #4567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khanhtc1202 merged 1 commit into from
Aug 25, 2023
Merged

Support update service which contains serviceRegistries #4567

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/app/piped/platformprovider/ecs/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,10 @@ func (c *client) UpdateService(ctx context.Context, service types.Service) (*typ
// Hack: Since we use EXTERNAL deployment controller, the below configurations are not allowed to be passed
// in UpdateService step, but it required in further step (CreateTaskSet step). We reassign those values
// as part of service definition for that purpose.
// ref: https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_CreateService.html
output.Service.LaunchType = service.LaunchType
output.Service.NetworkConfiguration = service.NetworkConfiguration
output.Service.ServiceRegistries = service.ServiceRegistries

return output.Service, nil
}
Expand Down