Skip to content

Add running log for migration task runner #3791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khanhtc1202 merged 1 commit into from
Jul 5, 2022
+8 −2
Merged

Add running log for migration task runner #3791

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions pkg/app/ops/platformprovidermigration/runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ package platformprovidermigration

import (
"context"
"fmt"
"time"

"go.uber.org/zap"
Expand Down Expand Up @@ -51,10 +52,13 @@ func (r *Runner) Migrate(ctx context.Context) error {

// Run migration task once on start this ops migration.
cursor, err := r.migrate(ctx, "")
if err != nil {
r.logger.Error("unable to finish application platform provider migration task in first run", zap.Error(err))
if err == nil {
r.logger.Info("application migration task finished successfully")
return nil
}

r.logger.Error("unable to finish application platform provider migration task in first run", zap.Error(err))

taskRunTicker := time.NewTicker(migrationRunInterval)
defer taskRunTicker.Stop()

Expand Down Expand Up @@ -110,6 +114,8 @@ func (r *Runner) migrate(ctx context.Context, cursor string) (string, error) {
return "", nil
}

r.logger.Info(fmt.Sprintf("migrate platform provider value for %d application(s)", len(apps)))

for _, app := range apps {
if app.PlatformProvider != "" {
continue
Expand Down