Skip to content

Conversation

@knanao
Copy link
Member

@knanao knanao commented Jul 1, 2022

What this PR does / why we need it:
In order to test firestore integration test in CI, added the image of firestore emulator.
We'll test integration test around firestore with dockertest like this.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@knanao knanao force-pushed the firestore-emulator branch from db15d63 to 15f0e77 Compare July 1, 2022 08:43
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@nghialv nghialv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@knanao knanao merged commit 331d2a4 into master Jul 4, 2022
@knanao knanao deleted the firestore-emulator branch July 4, 2022 03:52
@github-actions github-actions bot mentioned this pull request Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants