Skip to content

Add encrypt secret option to the menu action on application detail page #3776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khanhtc1202 merged 1 commit into from
Jun 28, 2022
Merged

Add encrypt secret option to the menu action on application detail page #3776

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions web/src/components/application-detail-page/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {
import { setDeletingAppId } from "~/modules/delete-application";
import { DeleteApplicationDialog } from "../applications-page/application-list/delete-application-dialog";
import { DisableApplicationDialog } from "../applications-page/application-list/disable-application-dialog";
import { SealedSecretDialog } from "../applications-page/application-list/sealed-secret-dialog";
import { ApplicationDetail } from "./application-detail";
import { ApplicationStateView } from "./application-state-view";

Expand Down Expand Up @@ -46,6 +47,7 @@ export const ApplicationDetailPage: FC = memo(function ApplicationDetailPage() {

const [anchorEl, setAnchorEl] = useState<HTMLButtonElement | null>(null);
const [openDisableDialog, setOpenDisableDialog] = useState(false);
const [openEncryptSecretDialog, setOpenEncryptSecretDialog] = useState(false);

useEffect(() => {
if (applicationId) {
Expand All @@ -66,15 +68,20 @@ export const ApplicationDetailPage: FC = memo(function ApplicationDetailPage() {
selectById(state.applications, applicationId)
);

const handleEncryptSecretClick = (): void => {
setOpenEncryptSecretDialog(true);
setAnchorEl(null);
};

const handleEnableClick = useCallback(async () => {
await dispatch(enableApplication({ applicationId: applicationId }));
setAnchorEl(null);
}, [dispatch, applicationId]);

const handleDisableClick = useCallback(async () => {
const handleDisableClick = (): void => {
setOpenDisableDialog(true);
setAnchorEl(null);
}, []);
};

const handleDeleteClick = useCallback(() => {
dispatch(setDeletingAppId(applicationId));
Expand Down Expand Up @@ -110,13 +117,24 @@ export const ApplicationDetailPage: FC = memo(function ApplicationDetailPage() {
{app && app.disabled ? (
<MenuItem onClick={handleEnableClick}>Enable</MenuItem>
) : (
<MenuItem onClick={handleDisableClick}>Disable</MenuItem>
<>
<MenuItem onClick={handleEncryptSecretClick}>
Encrypt Secret
</MenuItem>
<MenuItem onClick={handleDisableClick}>Disable</MenuItem>
</>
)}
<MenuItem className={classes.warning} onClick={handleDeleteClick}>
Delete
</MenuItem>
</Menu>

<SealedSecretDialog
open={openEncryptSecretDialog}
applicationId={applicationId}
onClose={() => setOpenEncryptSecretDialog(false)}
/>

<DisableApplicationDialog
open={openDisableDialog}
applicationId={applicationId}
Expand Down