Fix the file path of event watcher config #3757
Conversation
| matcher = cfg.Matcher | ||
| handler = cfg.Handler | ||
| ) | ||
| notHandledEvents := w.eventLister.ListNotHandled(matcher.Name, matcher.Labels, milestone+1, numToMakeOutdated) |
There was a problem hiding this comment.
I start feeling that this RPC is being called quite frequently.
In the future, maybe we need to add a new RPC to check multiple events simultaneously.
There was a problem hiding this comment.
Exactly, but it's not so frequently in the current spec because the count of eventCfgs is equal to the count of apps and the count of e.Configs is almost to be one except for edge cases.
So Let's add a new RPC when we add a new event type.
There was a problem hiding this comment.
But if the project has a fairly large number of applications, the number of the RPC calls is likely to be high.🤔
There was a problem hiding this comment.
I see. It would be nice if the number of calls did not depend on the number of applications.
But it could be an improvement point.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: