Skip to content

Fix to add safe.directory before running git command #3753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knanao merged 2 commits into from
Jun 15, 2022
Merged

Fix to add safe.directory before running git command #3753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26d1b19
Fix to add safe.directory before running git command
knanao Jun 14, 2022
b838d9f
Fix the error sentence
knanao Jun 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions tool/actions-gh-release/git.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,3 +171,21 @@ func readFileAtCommit(ctx context.Context, gitExecPath, repoDir, filePath, commi

return bytes.TrimSpace(out), nil
}

func addSafeDirectory(ctx context.Context, gitExecPath, repoDir string) error {
args := []string{
"config",
"--global",
"--add",
"safe.directory",
repoDir,
}

cmd := exec.CommandContext(ctx, gitExecPath, args...)
cmd.Dir = repoDir
out, err := cmd.CombinedOutput()
if err != nil {
return fmt.Errorf("err: %w, out: %s", err, string(out))
}
return nil
}
4 changes: 4 additions & 0 deletions tool/actions-gh-release/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ func main() {
log.Fatal("GITHUB_WORKSPACE was not defined")
}

if err := addSafeDirectory(ctx, gitExecPath, workspace); err != nil {
log.Fatalf("Failed to add %s as a safe directory: %v\n", workspace, err)
}

cfg := &githubClientConfig{Token: args.Token}
ghClient := newGitHubClient(ctx, cfg)

Expand Down