Skip to content

Conversation

@khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Jun 14, 2022

What this PR does / why we need it:

This PR removes several deprecated fields from pipecd's models.

  • GITHUB_ENTERPRISE enum value as ProjectSSOConfig_Provider (marked 2 years ago: blame)
  • handled field in event model (marked 5 months ago: blame - before v0.26.0)
  • config_path field in ApplicationGitPath type (marked 2 years ago: blame)

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@khanhtc1202 khanhtc1202 changed the title Remove GITHUB_ENTERPRISE SSO type Remove deprecated fields from models Jun 14, 2022
@khanhtc1202 khanhtc1202 marked this pull request as ready for review June 14, 2022 10:36
@khanhtc1202 khanhtc1202 enabled auto-merge (squash) June 14, 2022 10:37
@nghialv
Copy link
Member

nghialv commented Jun 15, 2022

Can you list the time when each of them was deprecated?

@khanhtc1202
Copy link
Member Author

Can you list the time when each of them was deprecated?

Updated the PR description to add time when we marked it as deprecated

@nghialv
Copy link
Member

nghialv commented Jun 15, 2022

Thank you.

Copy link
Member

@nghialv nghialv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Copy link
Member

@knanao knanao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you go!

@khanhtc1202 khanhtc1202 merged commit a1cd3fb into master Jun 15, 2022
@khanhtc1202 khanhtc1202 deleted the remove-deprecated branch June 15, 2022 03:38
@github-actions github-actions bot mentioned this pull request Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants