Update control plane Helm chart to allow specifying service account for all components #3736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added serviceAccountName field. For example, someone manages kubernetes management service(e.g. EKS) and uses AWS IAM Authentication for Kubernetes, pipecd-** without pipecd-server cannot access to another AWS management service. Because, pipecd-* is managed by `default` service account. So, I fixed it.
sivchari
requested review from
Szarny,
khanhtc1202,
knanao and
nghialv
as code owners
Member
|
@sivchari Just nit about the PR title. How about this?
-->
|
sivchari
changed the title
Member
Author
Thanks！ I fixed it. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
I added serviceAccountName field.
For example, someone manages kubernetes management service(e.g. EKS) and uses AWS IAM Authentication for Kubernetes, pipecd-** except pipecd-server cannot access to another AWS management service. Because pipecd-* are managed by
defaultservice account. So, I fixed it.Which issue(s) this PR fixes
Does this PR introduce a user-facing change?: