Fix bug that Cloud Provider is always Kubernetes in "Show Piped config" dialog #3735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The root cause of this issue is that we use the ApplicationKind (an enum) as the cloud provider type in the application configuration. Before submitting the piped configuration to the control plane, we do unmarshal/marshal the piped configuration, an enum value is cast to int32 and when we need to cast it back, it turns out not working (the below image shows the error in detail - thx @Szarny )
To resolve that, this PR added a new type CloudProviderType (define it equal to string) and use that in all places refer to pipedCfg.cloudProvider.
Which issue(s) this PR fixes:
Fixes #3731
Does this PR introduce a user-facing change?: