Make piped upgrade version input box selectable #3734
Conversation
pkg/app/server/githubstore/store.go
Outdated
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package githubstore |
There was a problem hiding this comment.
I wonder about the need for this package.
Currently, it is quite simple so which way is better: adding this package or implementing it directly in the API. 🤔
There was a problem hiding this comment.
I thought the same too, but looks like the current web_api.go does not import any 3rd packages so I think maybe this package is needed 😅
There was a problem hiding this comment.
There was no special reason for that fact. Just because we do not need any 3rd packages yet.
So importing that github package directly is fine to me.
There was a problem hiding this comment.
okay, lets me address that. Thanks for clarifying 🙏
|
About the UI, how about keeping the version field as a text field box to allow users to input the desired version? So the returned versions should just be the suggestions to choose from, and users still be able to input by text. |
tbh, I think the same too. On going commit 😂 |
Kapture.2022-06-07.at.15.45.47.mp4@nghialv I updated the input component to allow free text as version input, ptal |
nghialv
left a comment
nghialv
left a comment
There was a problem hiding this comment.
Thank you. Great improvement. Can't wait to deliver this.
What this PR does / why we need it:
This PR makes the piped upgrade version input box selectable. The versions list is the first 6 items (6 latest releases - pre-release excluded) from pipecd github repo. The request for that versions list from github is done by pipecd control plane and web only fetches that list each time the settings/piped page is loaded.
Kapture.2022-06-07.at.14.08.33.mp4
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: