Skip to content

Conversation

@Szarny
Copy link
Contributor

@Szarny Szarny commented Jun 2, 2022

What this PR does / why we need it:

  1. Expand dialog width and add syntax highlighter for yaml
    image

  2. Make "Show the configuration" item disabled when piped config hasn't loaded yet.
    image

Which issue(s) this PR fixes:

Fixes partially #3712

Does this PR introduce a user-facing change?:

Refine web console UI/UX related to show Piped configuration feature

@Szarny
Copy link
Contributor Author

Szarny commented Jun 2, 2022

hold: #3716

Copy link
Member

@nghialv nghialv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice.

@Szarny
Copy link
Contributor Author

Szarny commented Jun 3, 2022

#3722 merged

@Szarny Szarny enabled auto-merge (squash) June 3, 2022 06:17
@knanao
Copy link
Member

knanao commented Jun 3, 2022

Nice improvement!

@Szarny Szarny merged commit 263f950 into pipe-cd:master Jun 3, 2022
@github-actions github-actions bot mentioned this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants