Skip to content

Conversation

@nghialv
Copy link
Member

@nghialv nghialv commented Jun 2, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

To: now,
}

a.logPersister.Infof("[%s] Run query: %q, in range: %s", a.cfg.Query, queryRange)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add the analyzer id into params?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it!

To: now,
}

a.logPersister.Infof("[%s] Run query: %q, in range: %s", a.cfg.Query, queryRange)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the params are mismatched?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right. 🤣

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it!

Copy link
Member

@knanao knanao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@nghialv nghialv enabled auto-merge (squash) June 2, 2022 04:36
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@nghialv nghialv merged commit 96a543e into master Jun 2, 2022
@nghialv nghialv deleted the alaysis-query branch June 2, 2022 04:55
@github-actions github-actions bot mentioned this pull request Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants