Skip to content

Conversation

@knanao
Copy link
Member

@knanao knanao commented Apr 11, 2022

What this PR does / why we need it:
Fix StageStatusMap to StageMap to increase versatility.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

GO_LINTER

The following files are not gofmt-ed. By commenting /golinter fmt, the formatted one will be appended to this pull request automatically.

pkg/model/deployment_test.go
--- pkg/model/deployment_test.go.orig
+++ pkg/model/deployment_test.go
@@ -89,10 +89,10 @@
 				},
 			},
 			want: map[string]*PipelineStage{
-				"stage1": &PipelineStage{
+				"stage1": {
 					Id: "stage1",
 				},
-				"stage2": &PipelineStage{
+				"stage2": {
 					Id: "stage2",
 				},
 			},

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.59%. This pull request increases coverage by 0.03%.

File Function Base Head Diff
pkg/model/deployment.go Deployment.StageMap -- 100.00% +100.00%
pkg/model/deployment.go Deployment.StageStatusMap 0.00% -- +-0.00%

@knanao
Copy link
Member Author

knanao commented Apr 11, 2022

/golinter fmt

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.59%. This pull request increases coverage by 0.03%.

File Function Base Head Diff
pkg/model/deployment.go Deployment.StageMap -- 100.00% +100.00%
pkg/model/deployment.go Deployment.StageStatusMap 0.00% -- +-0.00%

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.60%. This pull request increases coverage by 0.04%.

File Function Base Head Diff
pkg/model/deployment.go StageStatus.IsCompleted -- 0.00% +0.00%
pkg/model/deployment.go Deployment.StageMap -- 100.00% +100.00%
pkg/model/deployment.go IsCompletedStage 0.00% -- +-0.00%
pkg/model/deployment.go Deployment.StageStatusMap 0.00% -- +-0.00%

@knanao knanao force-pushed the deployment-model branch from b7f6bcb to 1aa337a Compare April 11, 2022 04:20
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.60%. This pull request increases coverage by 0.04%.

File Function Base Head Diff
pkg/model/deployment.go StageStatus.IsCompleted -- 0.00% +0.00%
pkg/model/deployment.go Deployment.StageMap -- 100.00% +100.00%
pkg/model/deployment.go IsCompletedStage 0.00% -- +-0.00%
pkg/model/deployment.go Deployment.StageStatusMap 0.00% -- +-0.00%

@pipecd-bot pipecd-bot added size/L and removed size/M labels Apr 11, 2022
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.61%. This pull request increases coverage by 0.05%.

File Function Base Head Diff
pkg/model/deployment.go StageStatus.IsCompleted -- 100.00% +100.00%
pkg/model/deployment.go Deployment.StageMap -- 100.00% +100.00%
pkg/model/deployment.go IsCompletedStage 0.00% -- +-0.00%
pkg/model/deployment.go Deployment.StageStatusMap 0.00% -- +-0.00%

@khanhtc1202
Copy link
Member

Nice
/lgtm

@nghialv
Copy link
Member

nghialv commented Apr 11, 2022

👍
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 07295f2 into master Apr 11, 2022
@pipecd-bot pipecd-bot deleted the deployment-model branch April 11, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants