-
Notifications
You must be signed in to change notification settings - Fork 217
Handle declared type #3512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Handle declared type #3512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Code coverage for golang is
|
khanhtc1202
commented
Apr 8, 2022
Collaborator
|
Code coverage for golang is
|
Member
|
👍 /lgtm |
knanao
reviewed
Apr 11, 2022
Member
knanao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
/approve
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Previously, for queries of kind
{ Field: "Kind", Operator: datastore.OperatorEqual, Value: model.ApplicationKind_KUBERNETES, }the filter logic of filedb will return false even the model object has field Kind of the same value. That is caused by the unmarshaled model object only contains primitive types (to keep filedb layer generic, we only cast raw byte of models to map[string]interface{}, not it true type), and the operand value from queries is of its wrapped type (for instance
model.ApplicationKind). As the result, comparing those two values will return(mismatched type model.ApplicationKind and float64)error. This PR provides logic to convert types which not a primitive type of filter.Value to primitive types, so the filter compare logic could work.Which issue(s) this PR fixes:
Fixes #3494
Does this PR introduce a user-facing change?: