Skip to content

Conversation

@na-ga
Copy link
Contributor

@na-ga na-ga commented Apr 7, 2022

What this PR does / why we need it:

https://pipecd.dev/docs/user-guide/configuration-reference/#kubernetesdeploymentinput

Which issue(s) this PR fixes:

Fixes #3495

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

CLA

Welcome @na-ga!

Thanks for your contributing. It looks like this is your first PR to this repository 🎉. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). Please read the CLA and leave a /cla sign comment on this pull request to sign the CLA.

@pipecd-bot pipecd-bot requested review from knanao and nghialv April 7, 2022 08:28
@na-ga
Copy link
Contributor Author

na-ga commented Apr 7, 2022

/cla sign

@pipecd-bot
Copy link
Collaborator

CLA

Thank you for signing the CLA. Your signing has been successfully committed.

@khanhtc1202
Copy link
Member

Nice catch ⚾
/lgtm

@pipecd-bot pipecd-bot added the lgtm label Apr 7, 2022
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.56%. This pull request does not change code coverage.

@knanao
Copy link
Member

knanao commented Apr 7, 2022

Thanks.
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by knanao.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants