-
Notifications
You must be signed in to change notification settings - Fork 204
Fix codegen script #3413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix codegen script #3413
Conversation
|
A Kapetanios build has just been triggered to run docker operations for the following
|
|
The following files are not gofmt-ed. By commenting pkg/app/piped/cloudprovider/kubernetes/providertest/provider.mock.go--- pkg/app/piped/cloudprovider/kubernetes/providertest/provider.mock.go.orig
+++ pkg/app/piped/cloudprovider/kubernetes/providertest/provider.mock.go
@@ -9,6 +9,7 @@
reflect "reflect"
gomock "github.com/golang/mock/gomock"
+
kubernetes "github.com/pipe-cd/pipecd/pkg/app/piped/cloudprovider/kubernetes"
)
|
|
The Kapetanios build to run docker operations for the following 1. dockers/codegen - successAn image named codegen:0.7.0-391c7f5 was procuded for reviewing and testing. There is no test to run inside this directory. |
|
A Kapetanios build has just been triggered to run docker operations for the following
|
|
The following files are not gofmt-ed. By commenting pkg/model/project.pb.go--- pkg/model/project.pb.go.orig
+++ pkg/model/project.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/app/piped/cloudprovider/kubernetes/kubernetestest/kubernetes.mock.go--- pkg/app/piped/cloudprovider/kubernetes/kubernetestest/kubernetes.mock.go.orig
+++ pkg/app/piped/cloudprovider/kubernetes/kubernetestest/kubernetes.mock.go
@@ -9,6 +9,7 @@
reflect "reflect"
gomock "github.com/golang/mock/gomock"
+
kubernetes "github.com/pipe-cd/pipecd/pkg/app/piped/cloudprovider/kubernetes"
)
|
|
The Kapetanios build to run docker operations for the following 1. dockers/codegen - successAn image named codegen:0.7.0-b2ecc6d was procuded for reviewing and testing. There is no test to run inside this directory. |
|
Really nice catch! /approve |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: