Skip to content

Conversation

@knanao
Copy link
Member

@knanao knanao commented Mar 17, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

DOCKER

A Kapetanios build has just been triggered to run docker operations for the following 1 directory.
Their results will be reported back after the build is completed.

  1. dockers/codegen

@pipecd-bot
Copy link
Collaborator

GO_LINTER

The following files are not gofmt-ed. By commenting /golinter fmt, the formatted one will be appended to this pull request automatically.

pkg/app/piped/cloudprovider/kubernetes/providertest/provider.mock.go
--- pkg/app/piped/cloudprovider/kubernetes/providertest/provider.mock.go.orig
+++ pkg/app/piped/cloudprovider/kubernetes/providertest/provider.mock.go
@@ -9,6 +9,7 @@
 	reflect "reflect"
 
 	gomock "github.com/golang/mock/gomock"
+
 	kubernetes "github.com/pipe-cd/pipecd/pkg/app/piped/cloudprovider/kubernetes"
 )
 

@pipecd-bot
Copy link
Collaborator

DOCKER

The Kapetanios build to run docker operations for the following 1 directory has been completed.

1. dockers/codegen - success

An image named codegen:0.7.0-391c7f5 was procuded for reviewing and testing.
By merging this PR, an image named codegen:0.7.0 will be pushed to the container registry.

There is no test to run inside this directory.

@pipecd-bot
Copy link
Collaborator

DOCKER

A Kapetanios build has just been triggered to run docker operations for the following 1 directory.
Their results will be reported back after the build is completed.

  1. dockers/codegen

@pipecd-bot
Copy link
Collaborator

GO_LINTER

The following files are not gofmt-ed. By commenting /golinter fmt, the formatted one will be appended to this pull request automatically.

pkg/model/project.pb.go
--- pkg/model/project.pb.go.orig
+++ pkg/model/project.pb.go
@@ -21,11 +21,12 @@
 package model
 
 import (
+	reflect "reflect"
+	sync "sync"
+
 	_ "github.com/envoyproxy/protoc-gen-validate/validate"
 	protoreflect "google.golang.org/protobuf/reflect/protoreflect"
 	protoimpl "google.golang.org/protobuf/runtime/protoimpl"
-	reflect "reflect"
-	sync "sync"
 )
 
 const (
pkg/app/piped/cloudprovider/kubernetes/kubernetestest/kubernetes.mock.go
--- pkg/app/piped/cloudprovider/kubernetes/kubernetestest/kubernetes.mock.go.orig
+++ pkg/app/piped/cloudprovider/kubernetes/kubernetestest/kubernetes.mock.go
@@ -9,6 +9,7 @@
 	reflect "reflect"
 
 	gomock "github.com/golang/mock/gomock"
+
 	kubernetes "github.com/pipe-cd/pipecd/pkg/app/piped/cloudprovider/kubernetes"
 )
 

@pipecd-bot
Copy link
Collaborator

DOCKER

The Kapetanios build to run docker operations for the following 1 directory has been completed.

1. dockers/codegen - success

An image named codegen:0.7.0-b2ecc6d was procuded for reviewing and testing.
By merging this PR, an image named codegen:0.7.0 will be pushed to the container registry.

There is no test to run inside this directory.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.11%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Mar 17, 2022

Really nice catch!
Thank you.

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 8a917b7 into master Mar 17, 2022
@pipecd-bot pipecd-bot deleted the codegen branch March 17, 2022 12:56
@pipecd-bot
Copy link
Collaborator

TEMPLATE

failed to handle template rule manifests

Details
Error: unabled to get files: [manifests]

This was referenced Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants