Skip to content

Conversation

@knanao
Copy link
Member

@knanao knanao commented Mar 17, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

GO_LINTER

The following files are not gofmt-ed. By commenting /golinter fmt, the formatted one will be appended to this pull request automatically.

pkg/model/project.pb.go
--- pkg/model/project.pb.go.orig
+++ pkg/model/project.pb.go
@@ -21,11 +21,12 @@
 package model
 
 import (
+	reflect "reflect"
+	sync "sync"
+
 	_ "github.com/envoyproxy/protoc-gen-validate/validate"
 	protoreflect "google.golang.org/protobuf/reflect/protoreflect"
 	protoimpl "google.golang.org/protobuf/runtime/protoimpl"
-	reflect "reflect"
-	sync "sync"
 )
 
 const (

@nghialv
Copy link
Member

nghialv commented Mar 17, 2022

Nice catch!

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@nghialv nghialv changed the title Fix typo Fix a typo Mar 17, 2022
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.11%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 78.33%. This pull request increases coverage by 0.05%.

File Base Head Diff
src/modules/project/index.ts 56.60% 60.38% +3.77%

@pipecd-bot pipecd-bot merged commit 9dd5183 into master Mar 17, 2022
@pipecd-bot pipecd-bot deleted the chore branch March 17, 2022 10:16
This was referenced Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants