Skip to content

Conversation

@Hosshii
Copy link
Member

@Hosshii Hosshii commented Mar 10, 2022

What this PR does / why we need it:
Add t.Parallel to execute tests in parallel. And delete unused test files.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is NOT APPROVED. It will be approved when one of the following conditions is met:

  • Received a comment that contains /approve from an approver.
  • Received approval at review changes UI from at least 1 approvers.

@pipecd-bot
Copy link
Collaborator

GO_LINTER

The following files are not gofmt-ed. By commenting /golinter fmt, the formatted one will be appended to this pull request automatically.

pkg/log/log_test.go
--- pkg/log/log_test.go.orig
+++ pkg/log/log_test.go
@@ -60,11 +60,11 @@
 	t.Parallel()
 
 	configs := []Configs{
-		Configs{
+		{
 			Level:    "foo",
 			Encoding: "json",
 		},
-		Configs{
+		{
 			Level:    "info",
 			Encoding: "foo",
 		},

@Hosshii
Copy link
Member Author

Hosshii commented Mar 10, 2022

/golinter fmt

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.43%. This pull request increases coverage by 3.03%.

File Function Base Head Diff
pkg/app/piped/executor/waitapproval/waitapproval.go Register 66.67% 0.00% -66.67%
pkg/app/piped/executor/analysis/analysis.go Register 66.67% 0.00% -66.67%
pkg/app/piped/executor/cloudrun/cloudrun.go Register 66.67% 0.00% -66.67%
pkg/app/piped/executor/kubernetes/kubernetes.go Register 81.82% 0.00% -81.82%
pkg/app/piped/executor/lambda/lambda.go Register 71.43% 0.00% -71.43%
pkg/app/piped/apistore/analysisresultstore/store.go NewStore 0.00% -- +-0.00%
pkg/app/piped/apistore/analysisresultstore/store.go store.GetLatestAnalysisResult 0.00% -- +-0.00%
pkg/app/piped/apistore/analysisresultstore/store.go store.PutLatestAnalysisResult 0.00% -- +-0.00%
pkg/app/piped/apistore/applicationstore/store.go NewStore 0.00% -- +-0.00%
pkg/app/piped/apistore/applicationstore/store.go store.Run 0.00% -- +-0.00%
pkg/app/piped/apistore/applicationstore/store.go store.Lister 0.00% -- +-0.00%
pkg/app/piped/apistore/applicationstore/store.go store.sync 0.00% -- +-0.00%
pkg/app/piped/apistore/applicationstore/store.go store.List 0.00% -- +-0.00%
pkg/app/piped/apistore/applicationstore/store.go store.ListByCloudProvider 0.00% -- +-0.00%
pkg/app/piped/apistore/applicationstore/store.go store.Get 0.00% -- +-0.00%
pkg/app/piped/apistore/commandstore/store.go NewStore 0.00% -- +-0.00%
pkg/app/piped/apistore/commandstore/store.go store.Run 0.00% -- +-0.00%
pkg/app/piped/apistore/commandstore/store.go store.Lister 0.00% -- +-0.00%
pkg/app/piped/apistore/commandstore/store.go store.sync 0.00% -- +-0.00%
pkg/app/piped/apistore/commandstore/store.go store.cleanHandledCommands 0.00% -- +-0.00%
pkg/app/piped/apistore/commandstore/store.go store.ListApplicationCommands 0.00% -- +-0.00%
pkg/app/piped/apistore/commandstore/store.go store.ListDeploymentCommands 0.00% -- +-0.00%
pkg/app/piped/apistore/commandstore/store.go store.ListStageCommands 0.00% -- +-0.00%
pkg/app/piped/apistore/commandstore/store.go store.ListBuildPlanPreviewCommands 0.00% -- +-0.00%
pkg/app/piped/apistore/commandstore/store.go store.makeReportableCommand 0.00% -- +-0.00%
pkg/app/piped/apistore/commandstore/store.go store.reportCommandHandled 0.00% -- +-0.00%
pkg/app/piped/apistore/deploymentstore/store.go NewStore 0.00% -- +-0.00%
pkg/app/piped/apistore/deploymentstore/store.go store.Run 0.00% -- +-0.00%
pkg/app/piped/apistore/deploymentstore/store.go store.Lister 0.00% -- +-0.00%
pkg/app/piped/apistore/deploymentstore/store.go store.sync 0.00% -- +-0.00%
pkg/app/piped/apistore/deploymentstore/store.go store.ListPendings 0.00% -- +-0.00%
pkg/app/piped/apistore/deploymentstore/store.go store.ListPlanneds 0.00% -- +-0.00%
pkg/app/piped/apistore/deploymentstore/store.go store.ListRunnings 0.00% -- +-0.00%
pkg/app/piped/apistore/deploymentstore/store.go store.ListAppHeadDeployments 0.00% -- +-0.00%
pkg/app/piped/apistore/eventstore/store.go NewStore 0.00% -- +-0.00%
pkg/app/piped/apistore/eventstore/store.go store.Run 0.00% -- +-0.00%
pkg/app/piped/apistore/eventstore/store.go store.sync 0.00% -- +-0.00%
pkg/app/piped/apistore/eventstore/store.go store.ListNotHandled 0.00% -- +-0.00%
pkg/app/piped/apistore/eventstore/store.go store.Lister 0.00% -- +-0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go WithoutColor 0.00% -- +-0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go WithVars 0.00% -- +-0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go WithVarFiles 0.00% -- +-0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go WithAdditionalFlags 0.00% -- +-0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go WithAdditionalEnvs 0.00% -- +-0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go NewTerraform 0.00% -- +-0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go Terraform.Version 0.00% -- +-0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go Terraform.Init 0.00% -- +-0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go Terraform.SelectWorkspace 0.00% -- +-0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go PlanResult.NoChanges 0.00% -- +-0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go GetExitCode 0.00% -- +-0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go Terraform.Plan 0.00% -- +-0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go Terraform.makeCommonCommandArgs 0.00% -- +-0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go stripAnsiCodes 0.00% -- +-0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go parsePlanResult 0.00% -- +-0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go Terraform.Apply 0.00% -- +-0.00%
pkg/app/piped/controller/controller.go NewController 0.00% -- +-0.00%
pkg/app/piped/controller/controller.go controller.Run 0.00% -- +-0.00%
pkg/app/piped/controller/controller.go controller.shutdown 0.00% -- +-0.00%
pkg/app/piped/controller/controller.go controller.checkCommands 0.00% -- +-0.00%
pkg/app/piped/controller/controller.go controller.syncPlanners 0.00% -- +-0.00%
pkg/app/piped/controller/controller.go controller.startNewPlanner 0.00% -- +-0.00%
pkg/app/piped/controller/controller.go controller.syncSchedulers 0.00% -- +-0.00%
pkg/app/piped/controller/controller.go controller.startNewScheduler 0.00% -- +-0.00%
pkg/app/piped/controller/controller.go controller.getMostRecentlySuccessfulDeployment 0.00% -- +-0.00%
pkg/app/piped/controller/controller.go controller.shouldStartPlanningDeployment 0.00% -- +-0.00%
pkg/app/piped/controller/controller.go controller.cancelDeployment 0.00% -- +-0.00%
pkg/app/piped/controller/controller.go appLiveResourceLister.ListKubernetesResources 0.00% -- +-0.00%
pkg/app/piped/controller/controller.go reportApplicationDeployingStatus 0.00% -- +-0.00%
pkg/app/piped/controller/planner.go newPlanner 0.00% -- +-0.00%
pkg/app/piped/controller/planner.go planner.ID 0.00% -- +-0.00%
pkg/app/piped/controller/planner.go planner.IsDone 0.00% -- +-0.00%
pkg/app/piped/controller/planner.go planner.DoneTimestamp 0.00% -- +-0.00%
pkg/app/piped/controller/planner.go planner.DoneDeploymentStatus 0.00% -- +-0.00%
pkg/app/piped/controller/planner.go planner.Cancel 0.00% -- +-0.00%
pkg/app/piped/controller/planner.go planner.Run 0.00% -- +-0.00%
pkg/app/piped/controller/planner.go planner.reportDeploymentPlanned 0.00% -- +-0.00%
pkg/app/piped/controller/planner.go planner.reportDeploymentFailed 0.00% -- +-0.00%
pkg/app/piped/controller/planner.go planner.reportDeploymentCancelled 0.00% -- +-0.00%
pkg/app/piped/controller/planner.go planner.getMentionedAccounts 0.00% -- +-0.00%
pkg/app/piped/controller/scheduler.go newScheduler 0.00% -- +-0.00%
pkg/app/piped/controller/scheduler.go scheduler.ID 0.00% -- +-0.00%
pkg/app/piped/controller/scheduler.go scheduler.CommitHash 0.00% -- +-0.00%
pkg/app/piped/controller/scheduler.go scheduler.ConfigFilename 0.00% -- +-0.00%
pkg/app/piped/controller/scheduler.go scheduler.IsDone 0.00% -- +-0.00%
pkg/app/piped/controller/scheduler.go scheduler.DoneTimestamp 0.00% -- +-0.00%
pkg/app/piped/controller/scheduler.go scheduler.DoneDeploymentStatus 0.00% -- +-0.00%
pkg/app/piped/controller/scheduler.go scheduler.Cancel 0.00% -- +-0.00%
pkg/app/piped/controller/scheduler.go scheduler.Run 0.00% -- +-0.00%
pkg/app/piped/controller/scheduler.go scheduler.executeStage 0.00% -- +-0.00%
pkg/app/piped/controller/scheduler.go scheduler.reportStageStatus 0.00% -- +-0.00%
pkg/app/piped/controller/scheduler.go scheduler.reportDeploymentStatusChanged 0.00% -- +-0.00%
pkg/app/piped/controller/scheduler.go scheduler.reportDeploymentCompleted 0.00% -- +-0.00%
pkg/app/piped/controller/scheduler.go scheduler.getMentionedAccounts 0.00% -- +-0.00%
pkg/app/piped/controller/scheduler.go scheduler.reportMostRecentlySuccessfulDeployment 0.00% -- +-0.00%
pkg/app/piped/controller/scheduler.go stageCommandLister.ListCommands 0.00% -- +-0.00%
pkg/app/piped/controller/scheduler.go appAnalysisResultStore.GetLatestAnalysisResult 0.00% -- +-0.00%
pkg/app/piped/controller/scheduler.go appAnalysisResultStore.PutLatestAnalysisResult 0.00% -- +-0.00%
pkg/app/piped/deploysource/deploysource.go NewProvider 0.00% -- +-0.00%
pkg/app/piped/deploysource/deploysource.go provider.Revision 0.00% -- +-0.00%
pkg/app/piped/deploysource/deploysource.go provider.Get 0.00% -- +-0.00%
pkg/app/piped/deploysource/deploysource.go provider.GetReadOnly 0.00% -- +-0.00%
pkg/app/piped/deploysource/deploysource.go provider.prepare 0.00% -- +-0.00%
pkg/app/piped/deploysource/deploysource.go provider.copy 0.00% -- +-0.00%
pkg/app/piped/deploysource/sourcecloner.go NewGitSourceCloner 0.00% -- +-0.00%
pkg/app/piped/deploysource/sourcecloner.go gitSourceCloner.Revision 0.00% -- +-0.00%
pkg/app/piped/deploysource/sourcecloner.go gitSourceCloner.RevisionName 0.00% -- +-0.00%
pkg/app/piped/deploysource/sourcecloner.go gitSourceCloner.Clone 0.00% -- +-0.00%
pkg/app/piped/deploysource/sourcecloner.go NewLocalSourceCloner 0.00% -- +-0.00%
pkg/app/piped/deploysource/sourcecloner.go localSourceCloner.Revision 0.00% -- +-0.00%
pkg/app/piped/deploysource/sourcecloner.go localSourceCloner.RevisionName 0.00% -- +-0.00%
pkg/app/piped/deploysource/sourcecloner.go localSourceCloner.Clone 0.00% -- +-0.00%
pkg/app/piped/executor/terraform/deploy.go deployExecutor.Execute 0.00% -- +-0.00%
pkg/app/piped/executor/terraform/deploy.go deployExecutor.ensureSync 0.00% -- +-0.00%
pkg/app/piped/executor/terraform/deploy.go deployExecutor.ensurePlan 0.00% -- +-0.00%
pkg/app/piped/executor/terraform/deploy.go deployExecutor.ensureApply 0.00% -- +-0.00%
pkg/app/piped/executor/terraform/rollback.go rollbackExecutor.Execute 0.00% -- +-0.00%
pkg/app/piped/executor/terraform/rollback.go rollbackExecutor.ensureRollback 0.00% -- +-0.00%
pkg/app/piped/executor/terraform/terraform.go Register 71.43% -- -71.43%
pkg/app/piped/executor/terraform/terraform.go showUsingVersion 0.00% -- +-0.00%
pkg/app/piped/executor/terraform/terraform.go selectWorkspace 0.00% -- +-0.00%
pkg/app/piped/executor/terraform/terraform.go findTerraform 0.00% -- +-0.00%
pkg/app/piped/executor/terraform/terraform.go findCloudProvider 0.00% -- +-0.00%
pkg/app/piped/statsreporter/reporter.go NewReporter 0.00% -- +-0.00%
pkg/app/piped/statsreporter/reporter.go reporter.Run 0.00% -- +-0.00%
pkg/app/piped/statsreporter/reporter.go reporter.report 0.00% -- +-0.00%
pkg/app/piped/toolregistry/install.go registry.installKubectl 0.00% -- +-0.00%
pkg/app/piped/toolregistry/install.go registry.installKustomize 70.59% -- -70.59%
pkg/app/piped/toolregistry/install.go registry.installHelm 70.59% -- -70.59%
pkg/app/piped/toolregistry/install.go registry.installTerraform 0.00% -- +-0.00%
pkg/app/piped/toolregistry/registry.go DefaultRegistry 100.00% -- -100.00%
pkg/app/piped/toolregistry/registry.go InitDefaultRegistry 77.78% -- -77.78%
pkg/app/piped/toolregistry/registry.go loadPreinstalledTool 43.75% -- -43.75%
pkg/app/piped/toolregistry/registry.go registry.Kubectl 0.00% -- +-0.00%
pkg/app/piped/toolregistry/registry.go registry.Kustomize 82.35% -- -82.35%
pkg/app/piped/toolregistry/registry.go registry.Helm 88.24% -- -88.24%
pkg/app/piped/toolregistry/registry.go registry.Terraform 0.00% -- +-0.00%
pkg/app/server/commandoutputstore/store.go NewStore 0.00% -- +-0.00%
pkg/app/server/commandoutputstore/store.go store.Get 0.00% -- +-0.00%
pkg/app/server/commandoutputstore/store.go store.Put 0.00% -- +-0.00%
pkg/app/server/commandoutputstore/store.go dataPath 0.00% -- +-0.00%
pkg/app/server/httpapi/auth_handler.go newAuthHandler 0.00% -- +-0.00%
pkg/app/server/httpapi/auth_handler.go authHandler.handleLogout 0.00% -- +-0.00%
pkg/app/server/httpapi/auth_handler.go authHandler.findSSOConfig 0.00% -- +-0.00%
pkg/app/server/httpapi/auth_handler.go authHandler.handleError 0.00% -- +-0.00%
pkg/app/server/httpapi/auth_handler.go makeTokenCookie 0.00% -- +-0.00%
pkg/app/server/httpapi/auth_handler.go makeExpiredTokenCookie 0.00% -- +-0.00%
pkg/app/server/httpapi/auth_handler.go makeStateCookie 0.00% -- +-0.00%
pkg/app/server/httpapi/auth_handler.go makeExpiredStateCookie 0.00% -- +-0.00%
pkg/app/server/httpapi/auth_handler.go makeErrorCookie 0.00% -- +-0.00%
pkg/app/server/httpapi/callback.go authHandler.handleCallback 0.00% -- +-0.00%
pkg/app/server/httpapi/callback.go checkState 0.00% -- +-0.00%
pkg/app/server/httpapi/callback.go getUser 0.00% -- +-0.00%
pkg/app/server/httpapi/httpapi.go NewHandler 0.00% -- +-0.00%
pkg/app/server/httpapi/httpapimetrics/delegator.go responseWriterDelegator.Status 0.00% -- +-0.00%
pkg/app/server/httpapi/httpapimetrics/delegator.go responseWriterDelegator.Written 0.00% -- +-0.00%
pkg/app/server/httpapi/httpapimetrics/delegator.go responseWriterDelegator.WriteHeader 0.00% -- +-0.00%
pkg/app/server/httpapi/httpapimetrics/delegator.go responseWriterDelegator.Write 0.00% -- +-0.00%
pkg/app/server/httpapi/httpapimetrics/delegator.go closeNotifierDelegator.CloseNotify 0.00% -- +-0.00%
pkg/app/server/httpapi/httpapimetrics/delegator.go flusherDelegator.Flush 0.00% -- +-0.00%
pkg/app/server/httpapi/httpapimetrics/delegator.go hijackerDelegator.Hijack 0.00% -- +-0.00%
pkg/app/server/httpapi/httpapimetrics/delegator.go readerFromDelegator.ReadFrom 0.00% -- +-0.00%
pkg/app/server/httpapi/httpapimetrics/delegator.go pusherDelegator.Push 0.00% -- +-0.00%
pkg/app/server/httpapi/httpapimetrics/delegator.go init 50.00% -- -50.00%
pkg/app/server/httpapi/httpapimetrics/delegator.go newDelegator 0.00% -- +-0.00%
pkg/app/server/httpapi/httpapimetrics/handler.go Register 0.00% -- +-0.00%
pkg/app/server/httpapi/httpapimetrics/handler.go Handler 0.00% -- +-0.00%
pkg/app/server/httpapi/httpapimetrics/handler.go labels 0.00% -- +-0.00%
pkg/app/server/httpapi/httpapimetrics/handler.go sanitizeMethod 0.00% -- +-0.00%
pkg/app/server/httpapi/httpapimetrics/handler.go sanitizeCode 0.00% -- +-0.00%
pkg/app/server/httpapi/login.go authHandler.handleSSOLogin 0.00% -- +-0.00%
pkg/app/server/httpapi/login.go authHandler.handleStaticAdminLogin 0.00% -- +-0.00%

@Hosshii Hosshii closed this Mar 10, 2022
@pipecd-bot pipecd-bot deleted the add_parallel_3 branch March 10, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants