Skip to content

Revert SealedSecrets field in configuration to keep old config able to be loaded #2872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pipecd-bot merged 1 commit into from
Dec 1, 2021
Merged

Revert SealedSecrets field in configuration to keep old config able to be loaded #2872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pkg/app/piped/trigger/trigger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,12 @@ func (t *Trigger) checkRepoCandidates(ctx context.Context, repoID string, cs []c

appCfg, err := loadDeploymentConfiguration(gitRepo.GetPath(), app)
if err != nil {
t.logger.Error("failed to load application config file", zap.Error(err))
t.logger.Error("failed to load application config file",
zap.String("app", app.Name),
zap.String("app-id", app.Id),
zap.String("commit", headCommit.Hash),
zap.Error(err),
)
// Do not notify this event to external services because it may cause annoying
// when one application is missing or having an invalid configuration file.
// So instead of notifying this as a notification,
Expand Down
3 changes: 3 additions & 0 deletions pkg/config/deployment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@ type GenericDeploymentSpec struct {
Encryption *SecretEncryption `json:"encryption"`
// Additional configuration used while sending notification to external services.
DeploymentNotification *DeploymentNotification `json:"notification"`
// The list of sealed secrets that should be decrypted.
// Deprecated.
SealedSecrets []SealedSecretMapping `json:"sealedSecrets"`
}

type DeploymentPlanner struct {
Expand Down