Skip to content

Temporarily disable appconfig reporter in Piped #2868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pipecd-bot merged 1 commit into from
Dec 1, 2021
Merged

Temporarily disable appconfig reporter in Piped #2868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/app/piped/appconfigreporter/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ go_test(
srcs = ["appconfigreporter_test.go"],
embed = [":go_default_library"],
deps = [
"//pkg/config:go_default_library",
"//pkg/model:go_default_library",
"@com_github_stretchr_testify//assert:go_default_library",
"@org_uber_go_zap//:go_default_library",
Expand Down
30 changes: 15 additions & 15 deletions pkg/app/piped/cmd/piped/piped.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ import (
"github.com/pipe-cd/pipe/pkg/app/piped/apistore/deploymentstore"
"github.com/pipe-cd/pipe/pkg/app/piped/apistore/environmentstore"
"github.com/pipe-cd/pipe/pkg/app/piped/apistore/eventstore"
"github.com/pipe-cd/pipe/pkg/app/piped/appconfigreporter"
_ "github.com/pipe-cd/pipe/pkg/app/piped/appconfigreporter"
Copy link
Collaborator

@pipecd-bot pipecd-bot Dec 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a blank import should be only in a main or test package, or have a comment justifying it

"github.com/pipe-cd/pipe/pkg/app/piped/chartrepo"
k8scloudprovidermetrics "github.com/pipe-cd/pipe/pkg/app/piped/cloudprovider/kubernetes/kubernetesmetrics"
"github.com/pipe-cd/pipe/pkg/app/piped/controller"
Expand Down Expand Up @@ -448,20 +448,20 @@ func (p *piped) run(ctx context.Context, input cli.Input) (runErr error) {
}

// Start running app-config-reporter.
{
r := appconfigreporter.NewReporter(
apiClient,
gitClient,
applicationLister,
cfg,
p.gracePeriod,
input.Logger,
)

group.Go(func() error {
return r.Run(ctx)
})
}
// {
// r := appconfigreporter.NewReporter(
// apiClient,
// gitClient,
// applicationLister,
// cfg,
// p.gracePeriod,
// input.Logger,
// )

// group.Go(func() error {
// return r.Run(ctx)
// })
// }

// Wait until all piped components have finished.
// A terminating signal or a finish of any components
Expand Down