Skip to content

Conversation

@khanhtc1202
Copy link
Member

What this PR does / why we need it:

Hide the database migration post from blog table of content, since that version is staled and we're not going to support that migration script in the future.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 31.70%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Nov 29, 2021

/approve

@nakabonne
Copy link
Member

nakabonne commented Nov 29, 2021

This is a blog post, not documentation. I feel like you basically shouldn't delete it once you publish it even if it gets outdated as someone is still likely to refer to this page.

@nakabonne
Copy link
Member

/approve cancel

@nakabonne
Copy link
Member

I don't have a strong opinion so if you guys are fine, proceed as is.

@khanhtc1202
Copy link
Member Author

This is a blog post, not documentation. I feel like you basically shouldn't delete it once you publish it even if it gets outdated as someone is still likely to refer to this page.

I feel you, but the change I made here does not delete the post content. It's possible to access the post by URL directly, just hide it from the table of content list, since migration post may cause users to misunderstand that our PipeCD highly depends on a database, that may not good for the product image.

@nakabonne
Copy link
Member

That makese total sense. In that case fine to me 👍
There you go /approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants