Skip to content

Conversation

@khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Nov 26, 2021

What this PR does / why we need it:

Update dependencies:

  • bazel rules_nodejs to 4.4.6
  • nodejs to 16.13.0

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 84.24%. This pull request does not change code coverage.

@khanhtc1202 khanhtc1202 changed the title [WIP] Upgrade rules_nodejs Upgrade rules_nodejs Nov 26, 2021
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 31.69%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 84.24%. This pull request does not change code coverage.

@ono-max
Copy link
Member

ono-max commented Nov 26, 2021

/lgtm

@nakabonne
Copy link
Member

There you go
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit f0bc352 into master Nov 26, 2021
@pipecd-bot pipecd-bot deleted the upgrade-rules-nodejs branch November 26, 2021 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants