Skip to content

Conversation

@khanhtc1202
Copy link
Member

What this PR does / why we need it:

  • Remove unused ChainBlockIndex field from DeploymentChain model's block
  • Change type of DeploymentChainBlockIndex from int32 to uinit32

Which issue(s) this PR fixes:

As discussed in #2832 (comment)

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

GO_LINTER

The following files are not gofmt-ed. By commenting /golinter fmt, the formatted one will be appended to this pull request automatically.

pkg/app/api/grpcapi/piped_api.go
--- pkg/app/api/grpcapi/piped_api.go.orig
+++ pkg/app/api/grpcapi/piped_api.go
@@ -1053,7 +1053,7 @@
 
 		blockAppsMap[i+1] = blockApps
 		chainBlocks = append(chainBlocks, &model.ChainBlock{
-			Nodes: nodes,
+			Nodes:     nodes,
 			StartedAt: time.Now().Unix(),
 		})
 	}

@khanhtc1202 khanhtc1202 force-pushed the change-chain-block-index-type branch from 7dee15d to 098aed2 Compare November 24, 2021 10:18
@khanhtc1202 khanhtc1202 changed the title [WIP] Change DeploymentChainBlockIndex type Change DeploymentChainBlockIndex type Nov 24, 2021
@nakabonne
Copy link
Member

Thank you but it seems to be unable to build normally.

pkg/app/api/grpcapi/piped_api.go:1033:3: unknown field 'Index' in struct literal of type model.ChainBlock

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 31.73%. This pull request decreases coverage by -0.06%.

File Function Base Head Diff
pkg/app/piped/cloudprovider/kubernetes/state.go determineNameSpace -- 0.00% +0.00%
pkg/app/piped/cloudprovider/kubernetes/state.go determineResourceHealth 0.00% 0.00% +0.00%

@khanhtc1202
Copy link
Member Author

Thank you but it seems to be unable to build normally.

pkg/app/api/grpcapi/piped_api.go:1033:3: unknown field 'Index' in struct literal of type model.ChainBlock

Fixed, PTAL 😇

@ono-max
Copy link
Member

ono-max commented Nov 24, 2021

Nice.

/lgtm

@nghialv
Copy link
Member

nghialv commented Nov 24, 2021

Nice.
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 62097cf into master Nov 24, 2021
@pipecd-bot pipecd-bot deleted the change-chain-block-index-type branch November 24, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants