Skip to content

Conversation

@nakabonne
Copy link
Member

What this PR does / why we need it:
In order to get to know the kind of Application config defined in Git without any additional field, we need kind of like this a bit dirty method.

Which issue(s) this PR fixes:

Fixes #2807

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 31.87%. This pull request increases coverage by 0.04%.

File Function Base Head Diff
pkg/config/config.go Kind.ToApplicationKind -- 100.00% +100.00%
pkg/app/piped/appconfigreporter/appconfigreporter.go Reporter.readApplicationInfo 75.00% 73.33% -1.67%

@khanhtc1202
Copy link
Member

Nice
/lgtm

@nghialv
Copy link
Member

nghialv commented Nov 24, 2021

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit ce3e2b3 into master Nov 24, 2021
@pipecd-bot pipecd-bot deleted the kind-convert branch November 24, 2021 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert Kind string into dedicated type

5 participants