Skip to content

Conversation

@khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Nov 22, 2021

What this PR does / why we need it:

For deployment which be created to sync application in chain, we should add the ref to it in the chain model it belongs to, otherwise is keep as is for standalone deployment (deployment that does not belong to any chain called standalone deployment)

Which issue(s) this PR fixes:

Follow PR #2815

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

DOCKER

Unabled to get changed files of pull request.

Details
Error: rpc error: code = NotFound desc = not found

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 31.81%. This pull request decreases coverage by -0.03%.

File Function Base Head Diff
pkg/datastore/deploymentchainstore.go deploymentChainStore.UpdateDeploymentChain -- 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.CreateDeployment 0.00% 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.checkRepoCandidates 0.00% 0.00% +0.00%

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 31.81%. This pull request decreases coverage by -0.03%.

File Function Base Head Diff
pkg/datastore/deploymentchainstore.go deploymentChainStore.UpdateDeploymentChain -- 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.CreateDeployment 0.00% 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.checkRepoCandidates 0.00% 0.00% +0.00%

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 84.24%. This pull request does not change code coverage.

@nakabonne
Copy link
Member

found typo in PR title: Update CreateDeployment RCP -> Update CreateDeployment RPC

@nakabonne
Copy link
Member

makes sense
/lgtm

@khanhtc1202 khanhtc1202 changed the title Update CreateDeployment RCP to handle create in chain deployment Update CreateDeployment RPC to handle create in chain deployment Nov 24, 2021
@nghialv
Copy link
Member

nghialv commented Nov 24, 2021

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 234d69d into master Nov 24, 2021
@pipecd-bot pipecd-bot deleted the update-create-deployment branch November 24, 2021 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants