Skip to content

Conversation

@khanhtc1202
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2823

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

DOCKER

Unabled to get changed files of pull request.

Details
Error: rpc error: code = NotFound desc = not found

@pipecd-bot
Copy link
Collaborator

KAPETANIOS

Failed while validating Kapetanios configuration.

Details
Error: rpc error: code = NotFound desc = not found

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 31.84%. This pull request decreases coverage by -0.03%.

File Function Base Head Diff
pkg/app/piped/trigger/determiner.go NewOnChainDeterminer -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go OnChainDeterminer.ShouldTrigger -- 0.00% +0.00%
pkg/model/command.go Command.IsSyncApplicationCmd -- 0.00% +0.00%
pkg/model/command.go Command.IsChainSyncApplicationCmd -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go determiners.Determiner 0.00% 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.checkRepoCandidates 0.00% 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.listCommandCandidates 0.00% 0.00% +0.00%

@khanhtc1202
Copy link
Member Author

/trigger presubmits

@pipecd-bot
Copy link
Collaborator

TRIGGER

@khanhtc1202: Your requested presubmits has been scheduled in response to this comment.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 31.84%. This pull request decreases coverage by -0.03%.

File Function Base Head Diff
pkg/app/piped/trigger/determiner.go NewOnChainDeterminer -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go OnChainDeterminer.ShouldTrigger -- 0.00% +0.00%
pkg/model/command.go Command.IsSyncApplicationCmd -- 0.00% +0.00%
pkg/model/command.go Command.IsChainSyncApplicationCmd -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go determiners.Determiner 0.00% 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.checkRepoCandidates 0.00% 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.listCommandCandidates 0.00% 0.00% +0.00%

@nghialv
Copy link
Member

nghialv commented Nov 22, 2021

Nice.
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 190c357 into master Nov 22, 2021
@pipecd-bot pipecd-bot deleted the add-on-chain-determiner branch November 22, 2021 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ability to get deployment chain id from CHAIN_SYNC_APPLICATION command.

4 participants